1232456 - Create EGL surfaces through nsIWidget

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now we create EGL surfaces through AndroidBridge, but we should create them through nsIWidget to support multiple windows.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Create EGL surface through widget (v1)

This patch makes GLContextProviderEGL create EGL surfaces through
nsWindow/nsIWidget on Android. nsWindow then calls GLController in Java
to actually create the surface.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Save widget in GLContextEGL for renewing surface (v1)

This patch adds a widget member to GLContextEGL, so that it can later
use it to renew surfaces.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8698203 [details] [diff] [review]
Create EGL surface through widget (v1)

Review of attachment 8698203 [details] [diff] [review]:
-----------------------------------------------------------------

We want to kill GLController entirely eventually, but this is a good step towards that.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8698204 [details] [diff] [review]
Save widget in GLContextEGL for renewing surface (v1)

Review of attachment 8698204 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed, I don't think we want this. The compositor has the widget when it asks us to renew, so it should probably just pass it in.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Renew EGL surface using existing compositor widget (v1)

Add a widget parameter to RenewSurface so that the compositor can pass in its
widget.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8700124 [details] [diff] [review]
Renew EGL surface using existing compositor widget (v1)

Review of attachment 8700124 [details] [diff] [review]:
-----------------------------------------------------------------

I like it, but lets get another gfx person to review.

::: gfx/gl/GLContextEAGL.h
@@ +59,5 @@
>      virtual GLuint GetDefaultFramebuffer() override {
>          return mBackbufferFB;
>      }
>  
> +    virtual bool RenewSurface(nsIWidget* aWidget) override {

This is wrong for UIKit, but maybe just add something like:

// FIXME: should use the passed widget instead of the existing one

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b23cb28ee3d
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa4764e92630

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b23cb28ee3d
https://hg.mozilla.org/mozilla-central/rev/fa4764e92630