1227706 - Make each nsWindow/GeckoView manage their own compositor/GLController

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Each nsWindow should have its own compositor, and each GeckoView should manage its own GLController instance, because GLController is responsible for creating/pausing/resuming the compositor.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Make EGL initialization static (v1)

GLController will no longer be a singleton, but we should keep
initializing EGL only once, so this patch makes EGL initialization
static.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Rename nsWindow::Natives to nsWindow::GeckoViewSupport (v1)

GeckoViewSupport better reflects the purpose of the class and will match
the GLControllerSupport class that another patch is adding. This patch
also changes the way GeckoViewSupport is constructed in order to be more
encapsulating.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add native methods to GLController (v1)

One nsWindow will have one corresponding GLController, and using native
GLController methods instead of GeckoEvents lets us control the
compositor for each nsWindow separately.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Let GeckoView manage GLController instances (v1)

GLController instances are associated with a particular nsWindow, rather
than a particular View. Therefore, we need to let GeckoView manage
GLController instances, as part of GeckoView's handling of saving and
restoring states.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Implement nsWindow::GLControllerSupport (v1)

This patch adds native method implementations in GLControllerSupport to
manage compositor creation/pause/resume.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Get rid of compositor singletons in nsWindow (v1)

Now that we properly support individual compositors for nsWindows, we
should get rid of the static singletons that held the compositor
objects.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove unused GLController calls and events (v1)

Remove GLController calls and events in GeckoAppShell and GeckoEvent
that were made obsolete by the new native calls.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8698192 [details] [diff] [review]
Implement nsWindow::GLControllerSupport (v1)

Review of attachment 8698192 [details] [diff] [review]:
-----------------------------------------------------------------

This seems ok, but please test very thoroughly. This stuff is fragile.

::: widget/android/nsWindow.cpp
@@ +448,5 @@
> +    template<class Functor>
> +    static void OnNativeCall(Functor&& aCall)
> +    {
> +        if (aCall.IsTarget(&GLControllerSupport::CreateCompositor) ||
> +                aCall.IsTarget(&GLControllerSupport::PauseCompositor)) {

Fix indentation

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8698193 [details] [diff] [review]
Get rid of compositor singletons in nsWindow (v1)

Review of attachment 8698193 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/nsWindow.cpp
@@ +3018,5 @@
>      return sWidgetPaintsBackground;
>  }
>  
>  bool
>  nsWindow::NeedsPaint()

I don't even think this really gets used anymore...

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdae21cb55aa
https://hg.mozilla.org/integration/mozilla-inbound/rev/fca23dbf60cc
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ebeb391981b
https://hg.mozilla.org/integration/mozilla-inbound/rev/094dca979346
https://hg.mozilla.org/integration/mozilla-inbound/rev/23411cbf19f1
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec824e55926
https://hg.mozilla.org/integration/mozilla-inbound/rev/425588347628

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cdae21cb55aa
https://hg.mozilla.org/mozilla-central/rev/fca23dbf60cc
https://hg.mozilla.org/mozilla-central/rev/1ebeb391981b
https://hg.mozilla.org/mozilla-central/rev/094dca979346
https://hg.mozilla.org/mozilla-central/rev/23411cbf19f1
https://hg.mozilla.org/mozilla-central/rev/2ec824e55926
https://hg.mozilla.org/mozilla-central/rev/425588347628