Closed Bug 1232589 Opened 9 years ago Closed 9 years ago

wrap Cellular And Data panel into AMD module

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 file)

[gaia] gasolin:issue-1232589 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
We'd quickly wrap Cellular And Data panel to fit panel architecture
Assignee: nobody → gasolin
tracking-b2g: --- → backlog
Comment on attachment 8698347 [details] [review]
[gaia] gasolin:issue-1232589 > mozilla-b2g:master

Due to priority shift, let's wrap rest of js into AMD panels even without refactor & adding unit tests.

Test fine on device.
Attachment #8698347 - Flags: review?(yzenevich)
Comment on attachment 8698347 [details] [review]
[gaia] gasolin:issue-1232589 > mozilla-b2g:master

Looks good with just 1 nit.
Attachment #8698347 - Flags: review?(yzenevich) → review+
issue addressed, merged to master https://github.com/mozilla-b2g/gaia/commit/272a18a1457db9ee975fd7c3e0eff333f391265b

thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: