1232677 - On clean profile nightly startup, tab migration leaves an error in the browser console

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[:Gijs (he/him)]

STR:

1. Open 45+ on a clean profile

ER:
no errors


AR:

Failed to parse sessionstore state JSON to migrate tab groups: SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

We should just ignore an empty file.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws

Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8698450 [details]
MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws

https://reviewboard.mozilla.org/r/27997/#review25331

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ad758df8d567

Comment 4

[:Gijs (he/him)]

Comment on attachment 8698450 [details]
MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws

Approval Request Comment
[Feature/regressing bug #]: tab groups migration
[User impact if declined]: clean profile startup shows an error in the browser console for 45
[Describe test coverage new/current, TreeHerder]: not for this error and/or this particular method - but all we're adding is an early return in case the data is empty
[Risks and why]: very low, see previous point
[String/UUID change made/needed]: nope

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad758df8d567

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8698450 [details]
MozReview Request: Bug 1232677 - ignore empty state passed by session restore observer notification in the tab groups migration code, r?jaws

Tab migration related issue, taking it.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1ce623a9f899

Comment 8

[Brindusa Tot, DTE]

Verified as fixed on Nightly and Aurora builds as follows:

Nighlty builds:
Windows7 x64: 46.0a1 Build ID 	20151228030213 - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Ubuntu 14.04 x32: 46.0a1 Build ID 20151227030239 - Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
Mac 10.10: Build ID  20151229030216 - User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:46.0) Gecko/20100101 Firefox/46.0

Aurora builds:
Windows 7 x64: 45.0a2 Build ID 20151229004007 - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Ubuntu 14.04 x32: 45.0a2 Build ID20151228004010 - Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0
Mac 10.10: 45.0a2  Build ID  20151229004007 - User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Firefox/45.0