1232797 - The 2nd 'Enter PUK code' dialog (if 1st PUK dialog is skipped) lacks labeling on fields

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: screenshot of issue

Description:
The 'Enter PUK code' dialog does not label what the second and third fields are for. Note that this only happens if you skip the first PUK prompt.

STR:
1) Turn on or off (depending on your current setting) SIM Pin in Settings
2) Enter wrong SIM Pin three times
3) On the PUK prompt, tap anywhere on screen to dismiss keyboard, then tap the Skip button on the prompt
4) Attempt to turn on or off SIM Pin again, and observe the dialog

Expected: Dialog clearly labels all fields on this screen. Indicating what needs to be entered on there.

Actual: Only the first field is labeled with 'PUK code', the rest of fields are not labeled hence user wouldn't know what they're for. See screenshot.

Device: Aries 2.6
BuildID: 20151215145647
Gaia: ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Gecko: cb66ffeb6725e8344818e8e2f707ae2eaeb953b4
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Device: Flame 2.6
BuildID: 20151215030209
Gaia: ad15b4f1f50f4e28170a069f049e5bdeec8d15cc
Gecko: ae37fdb042c07c0cb9d0afcd41372a96454f4f4f
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat of issue

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

Flame 2.5 is also affected.

Device: Flame 2.5
BuildID: 20151215162548
Gaia: 062e0fa48c1b5d5156f6911a5a4519128fac3231
Gecko: 7fffe3f2990dad2297ca474296933f85b2a573ab
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

--------

Flame 2.2 is unaffected. 2nd field is labeled with 'Create PIN (must contain 4 to 8 digits)', and 3rd field 'Confirm new PIN'.

Device: Flame 2.2
BuildID: 20151215032500
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: 2c21da79a810
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

As entering wrong information on this screen could result in a locked screen, nominating it as a blocker.  Let's get a window.

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Correction: Entering wrong information on that screen can result in a locked SIM.

Comment 5

[John Thomas [:Johnt]]

In between my Last Working and First Broken builds there was an issue regarding some builds that pulled up a blank a SIM Security menu in Settings. I have provided the builds around this. I included the Central Window since the Gaia Pushlog appears to be much shorter, but also provided the B2G Inbound if this is of any extra use. 

Caused by changes made in Bug 1103808

CentralRegression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150212150405
Gaia: 2a2b008f9ae957fe19ad540d233d86b5c0b6829e
Gecko: 2f5c5ec1a24b
Version: 38.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150217074031
Gaia: ae02fbdeae77b2002cebe33c61aedeee4b9439fd
Gecko: 4bb425001d8a
Version: 38.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working gaia / First Broken gecko -Unaffected
Gaia: 2a2b008f9ae957fe19ad540d233d86b5c0b6829e
Gecko: 4bb425001d8a

Last Working gecko / First Broken gaia - Affected
Gecko: 2f5c5ec1a24b
Gaia: ae02fbdeae77b2002cebe33c61aedeee4b9439fd

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/2a2b008f9ae957fe19ad540d233d86b5c0b6829e...ae02fbdeae77b2002cebe33c61aedeee4b9439fd

==================================================

Caused by changes made in Bug 1103808

B2g Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150213082557
Gaia: f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gecko: 3bbbe722fbe7
Version: 38.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150217113115
Gaia: 189d6b3c4e44cfd28a92ce7dee4e06739f479feb
Gecko: fb9680492d09
Version: 38.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working gaia / First Broken gecko - This issue does NOT occur with with broken Gecko.
Gaia: f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gecko: fb9680492d09

Last Working gecko / First Broken gaia - This issue DOES occur with broken Gaia.
Gecko: 3bbbe722fbe7
Gaia: 189d6b3c4e44cfd28a92ce7dee4e06739f479feb

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/f0b93e0668ef9565bd6f050b15b4f794d59feb65...189d6b3c4e44cfd28a92ce7dee4e06739f479feb

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Eregon or Fred, can you please take a look at this issue?

Comment 7

[[e-mail]]

Scott, could you help take a look on this?

Comment 8

[Scott Wu [:scottwu]]

Ok no problem :)

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1232797-enter-puk-code-labels > mozilla-b2g:master

Comment 10

[Scott Wu [:scottwu]]

I found that the labels might only be missing for SIM1 and not SIM2, so it should work with the patch. However, actually triggering the PUK mode on a real SIM card would be somewhat problematic, so I have not tested it completely.

John, could you help me verify if the patch works?

Comment 11

[Scott Wu [:scottwu]]

Attachment: pinErrorMsg.png

Additionally, I think there's a missing string (pinErrorMsg).

Tina, do you have the UX spec that says what the string should be?

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

Scott, the pinerrormsg issue is being handled in bug 1232788.

Comment 13

[Pi Wei Cheng [:piwei] (inactive)]

I've verified that the patch at comment 9 fixes the issue. Tested on Flame and Aries. With the patch, all fields are labeled on this dialog, matching 2.2 behavior.

Comment 14

[Scott Wu [:scottwu]]

Comment on attachment 8699831 [details] [review]
[gaia] scottwu:1232797-enter-puk-code-labels > mozilla-b2g:master

Hi Fred, could you review this patch for me?

It's a small fix, using similar code from PUK2. Maybe someone forgot to copy it over.

Thanks!

Comment 15

[[e-mail]]

Comment on attachment 8699831 [details] [review]
[gaia] scottwu:1232797-enter-puk-code-labels > mozilla-b2g:master

Looks good, thanks!

Comment 16

[Scott Wu [:scottwu]]

Thanks a lot :gasolin and :piwei

Merged to master.

Comment 17

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results: The 2nd 'Enter PUK code' dialog (if 1st PUK dialog is skipped) has its label on fields.
See attachment: verified_Flame_master.3gp
Reproduce rate: 0/10


Device: Flame master_512mb (Pass)
Build ID               20151221150211
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151221.182728
Firmware Date          Mon Dec 21 18:27:42 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151221204910
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151221.200242
Firmware Date          Mon Dec 21 20:02:51 UTC 2015
Bootloader             s1

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.3gp