1232936 - There is a redundant check box in send information page.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[SandKing]

Attachment: Bug picture: Flame.png

[1.Description]:
[Flame v2.5&master][Aries KK v2.5&mater]Lose the network connection while the user is trying to sign in the gmail account in "Contacts"->"Import contacts" page, then connect the network and back to sign in page, you will see the send information prompt shows with a redundant check box.

See video:"Aries_v2.6.3gp"
See log:"logcat_0026.txt"
See picture:"Flame.png"
Found Time:00:26

[2.Testing Steps]: 
1. Connect a valid newtwork.
2. Launch "Contacts"->"Settings"->"Import Contacts"->"Gmail".
3. Input gmail address and password. 
4. Disconnect network then tap the "Sign in" button.
5. When the "No access to the Internet right now" box pops up, then tap the "Check settings" item.
6. Connect the network, and tap "Done" icon.
7. Observe the popup box.

[3.Expected Result]: 
7. Should not have the check box, or if it displays it, there should be remind words infront of check box.

[4.Actual Result]: 
7. There is a redundant check box

[5.Reproduction build]: 
Flame master_512M(Affected):
Build ID               20151215150203
Gaia Revision          ee43a95f2bbe39c5ac8c9fcdec76749a56c02f2e
Gaia Date              2015-12-15 04:30:46
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cb66ffeb6725e8344818e8e2f707ae2eaeb953b4
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151215.184537
Firmware Date          Tue Dec 15 18:45:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame v2.5_512M(Affected):
Build ID               20151215162548
Gaia Revision          062e0fa48c1b5d5156f6911a5a4519128fac3231
Gaia Date              2015-12-11 15:06:09
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7fffe3f2990dad2297ca474296933f85b2a573ab
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151215.153754
Firmware Date          Tue Dec 15 15:38:04 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Flame v2.2_512M(Unaffected):
Build ID               20151215032500
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2c21da79a810
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151215.071106
Firmware Date          Tue Dec 15 07:11:18 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Aries KK master(Affected):
Build ID               20151216003129
Gaia Revision          635c79fe14b5c4df919c20e7fc760c7a400ca7cc
Gaia Date              2015-12-15 17:39:35
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/e6463ae7eda2775bc84593bb4a0742940bb87379
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151216.001134
Firmware Date          Wed Dec 16 00:11:42 UTC 2015
Bootloader             s1

Aries KK v2.5(Affected):
Build ID               20151215163058
Gaia Revision          062e0fa48c1b5d5156f6911a5a4519128fac3231
Gaia Date              2015-12-11 15:06:09
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7fffe3f2990dad2297ca474296933f85b2a573ab
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151215.154602
Firmware Date          Tue Dec 15 15:46:10 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

Comment 1

[SandKing]

Attachment: Bug log: logcat_0026.txt

Comment 2

[SandKing]

Attachment: Bug video: Aries_v2.6.3GP

Comment 3

[Isabel Rios[:isabel_rios]]

[Blocking Requested - why for this release]: Nom since it is a regression

Comment 4

[Isabel Rios[:isabel_rios]]

Hi Gregor, this seems more like a system bug, what do you think?
Thanks!

Comment 5

[Gregor Wagner [:gwagner]]

I didn't know we even have this page.
No serious user impact so lets not block 2.5.

Comment 6

[John Thomas [:Johnt]]

Caused by changes made in Bug 1199864

B2g Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150831161447
Gaia: ed6674bcc194e4ad633bc8b14e8cf0250a7ae65f
Gecko: 82c02f45c982e45c022ad994508ce9d0c0de22ba
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150831163847
Gaia: 04c089a1e520752e2769acac0e15d486d5b150b1
Gecko: 90920c6a6787d7b916fe4d964815888e5c2dc79b
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0


Last Working gaia / First Broken gecko - This issue does NOT occur with broken Gecko.
Gaia: ed6674bcc194e4ad633bc8b14e8cf0250a7ae65f
Gecko: 90920c6a6787d7b916fe4d964815888e5c2dc79b

Last Working gecko / First Broken gaia - This issue DOES occur with broken Gaia.
Gecko: 82c02f45c982e45c022ad994508ce9d0c0de22ba
Gaia: 04c089a1e520752e2769acac0e15d486d5b150b1

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/ed6674bcc194e4ad633bc8b14e8cf0250a7ae65f...04c089a1e520752e2769acac0e15d486d5b150b1

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Kevin this issue seems to have been caused by the changes for bug 1199864.  Can you please take a look?

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1232936_system_app_modal_checkbox > mozilla-b2g:master

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8700651 [details] [review]
[gaia] KevinGrandon:bug_1232936_system_app_modal_checkbox > mozilla-b2g:master

I think this is a quick fix. Mike - could you give this a quick look? Thanks!

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8700651 [details] [review]
[gaia] KevinGrandon:bug_1232936_system_app_modal_checkbox > mozilla-b2g:master

Thanks!

Comment 11

[Kevin Grandon :kgrandon]

Thanks for the review! In master: https://github.com/mozilla-b2g/gaia/commit/0c18d68ee51d22fe3bc61dbc8df95915503add76

Comment 12

[Lance（leave from Mozilla）]

Attachment: Verified video: Flame KK master.3GP

This bug has been verified as "Pass" on the latest build of Flame KK master (512mb) and Aries KK master by the STR in comment 0.
Actual result: 
There isn't a redundant check box.
Occurrence rate: 0/10.

Device: Flame KK master 512mb (Pass)
Build ID               20151223030206
Gaia Revision          94cc99aac11339e297da186ec7153ca4ae9ab8cd
Gaia Date              2015-12-23 06:07:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/35b211eaad1fa828064514c547057e4400e24459
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151223.075116
Firmware Date          Wed Dec 23 07:51:28 EST 2015
Fireware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151223121756
Gaia Revision          94cc99aac11339e297da186ec7153ca4ae9ab8cd
Gaia Date              2015-12-23 06:07:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/35b211eaad1fa828064514c547057e4400e24459
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151223.113503
Firmware Date          Wed Dec 23 11:35:11 UTC 2015
Bootloader             s1

Comment 13

[Lance（leave from Mozilla）]

Attachment: Verified picture: Flame KK maser.png