1232962 - mach robocop busted: DMError: Non-zero return code for command: ['pm', 'list', 'packages', 'org.mozilla.']

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

I can't run 'mach robocop' locally anymore and see the following error. Note that I have a physical device plugged in and no emulator running.

TheSilence:fx-team sebastian$ ./mach robocop testRestrictions
Error running mach:

    ['robocop', 'testRestrictions']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=mach


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

DMError: Non-zero return code for command: ['pm', 'list', 'packages', 'org.mozilla.'] (output: 'error: device 'emulator-5554' not fou', retval: '5554')

  File "/Users/sebastian/Projects/Mozilla/fx-team/python/mach/mach/main.py", line 336, in run
    return self._run(argv)
  File "/Users/sebastian/Projects/Mozilla/fx-team/python/mach/mach/main.py", line 382, in _run
    args = parser.parse_args(argv)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1701, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1942, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1898, in consume_positionals
    take_action(action, args)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/argparse.py", line 1807, in take_action
    action(self, namespace, argument_values, option_string)
  File "/Users/sebastian/Projects/Mozilla/fx-team/python/mach/mach/dispatcher.py", line 185, in __call__
    if handler.parser:
  File "/Users/sebastian/Projects/Mozilla/fx-team/python/mach/mach/decorators.py", line 77, in parser
    self._parser = self._parser()
  File "/Users/sebastian/Projects/Mozilla/fx-team/testing/mochitest/mach_commands.py", line 378, in setup_argument_parser
    verify_android_device(build_obj, install=True, xre=True)
  File "/Users/sebastian/Projects/Mozilla/fx-team/testing/mozbase/mozrunner/mozrunner/devices/android_device.py", line 131, in verify_android_device
    'packages', 'org.mozilla.'])
  File "/Users/sebastian/Projects/Mozilla/fx-team/testing/mozbase/mozdevice/mozdevice/devicemanager.py", line 405, in shellCheckOutput
    raise DMError("Non-zero return code for command: %s (output: '%s', retval: '%s')" % (cmd, output, retval))

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

It seems like this change (hard-coding deviceSerial='emulator-5554') is causing this (bug 1231665):
https://hg.mozilla.org/mozilla-central/rev/7c790bfad7fe

Comment 2

[Geoff Brown [:gbrown]]

Attachment: use emulator device-serial for android-emulator command only

I neglected the fact that the AndroidEmulator class is used both by the android-emulator command and by the various mach test commands. "mach android-emulator" only needs to talk to emulator-5554, but the test commands may use a connected device.

This patch moves the device-serial specification back to the mach command level and only uses emulator-5554 for 'mach android-emulator'. That still solves the problem in bug 1231665 without breaking tests.

I tested 'mach android-emulator' and 'mach robocop <test>' against:
 - no device connected or emulator running
 - emulator running
 - good device connected
 - 'no permissions' device connected

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8699025 [details] [diff] [review]
use emulator device-serial for android-emulator command only

Review of attachment 8699025 [details] [diff] [review]:
-----------------------------------------------------------------

ah, I had to do a double take here, I see your fix!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68c00debbc80

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68c00debbc80