1233182 - crash in mozilla::layers::ContentClientDoubleBuffered::FinalizeFrame - 44 release only

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Bug 1200021 landed on 45 and 43, but 44 wasn't done.  We were waiting to see if the results were conclusive.  Along the way, bug 1200021 exposed a problem fixed in bug 1230740, currently only in 45.

The purpose of this bug is to track us doing the right thing in 44.  That should probably be patches from both bug 1200021 and bug 1230740.

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Milan, would you be able to help nominate the relevant patches for uplift to Beta44?

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Will do - bug 1230740 is on inbound, once it's on central for a few days, we can see what exactly we need.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

OK, looks like, for 44, we will want to uplift bug 1200021, combined with bug 1230740.  Because it's somewhat confusing, I'll put up a patch on this bug that is specific to 44, rather than try to uplift things form those two bugs.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Beta only patch for bug 1200021 and 1230740. Carry r=bas

Approval Request Comment
See discussion in bug 1200021, bug 1230740.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8703757 [details] [diff] [review]
Beta only patch for bug 1200021 and 1230740.  Carry r=bas

Both the fixes have been in Nightly and Aurora for a few weeks and the crash data looks promising, beta44+

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/35655c81d4e6

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

This may be a cause for new crashes in bug 1238257, I will investigate in that bug.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

Bad merge to produce the above patch, causing bug 1238257.

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Part 2 - two lines were reversed in the previous patch . r=botond

There is a problem with the first patch - this fixes it.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8706514 [details] [diff] [review]
Part 2 - two lines were reversed in the previous patch .  r=botond

Fixes a top crash, taking it. Beta44+

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Reverting to fx44 status to "affected" so it shows up on the queries Sheriff's use to look for beta+'d patches that still need to land.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0488d79e6d74

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0488d79e6d74