1233440 - Replace toast in HelperAppDialog.js with Snackbar.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1233440 - Replace toast in HelperAppDialog.js with Snackbar. r?mcomella

Review commit: https://reviewboard.mozilla.org/r/28259/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28259/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8699508 [details]
MozReview Request: Bug 1233440 - Replace toast in HelperAppDialog.js with Snackbar. r?mcomella

https://reviewboard.mozilla.org/r/28259/#review25341

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/6da91747a0c90f8794f9dbe8b87331f782fc5909
Bug 1233440 - Replace toast in HelperAppDialog.js with Snackbar. r=mcomella

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/28259/#review25419

::: mobile/android/components/HelperAppDialog.js:40
(Diff revision 1)
>    getNativeWindow: function () {

We could remove this helper method, right?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> https://reviewboard.mozilla.org/r/28259/#review25419
> 
> ::: mobile/android/components/HelperAppDialog.js:40
> (Diff revision 1)
> >    getNativeWindow: function () {
> 
> We could remove this helper method, right?

Yep, I filed bug 1234131 for that.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6da91747a0c9