Closed
Bug 1233440
Opened 9 years ago
Closed 9 years ago
Replace toast in HelperAppDialog.js with Snackbar.
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28259/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28259/
Attachment #8699508 -
Flags: review?(michael.l.comella)
Attachment #8699508 -
Flags: review?(michael.l.comella) → review+
Comment on attachment 8699508 [details]
MozReview Request: Bug 1233440 - Replace toast in HelperAppDialog.js with Snackbar. r?mcomella
https://reviewboard.mozilla.org/r/28259/#review25341
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6da91747a0c90f8794f9dbe8b87331f782fc5909
Bug 1233440 - Replace toast in HelperAppDialog.js with Snackbar. r=mcomella
|
||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/28259/#review25419
::: mobile/android/components/HelperAppDialog.js:40
(Diff revision 1)
> getNativeWindow: function () {
We could remove this helper method, right?
|
|
Assignee | |
Comment 5•9 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #4)
> https://reviewboard.mozilla.org/r/28259/#review25419
>
> ::: mobile/android/components/HelperAppDialog.js:40
> (Diff revision 1)
> > getNativeWindow: function () {
>
> We could remove this helper method, right?
Yep, I filed bug 1234131 for that.
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•