Remove unused method getNativeWindow() in HelperAppDialog.js

RESOLVED FIXED in Firefox 46

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: sebastian, Assigned: kartikey0303, Mentored)

Tracking

unspecified
Firefox 46
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(1 attachment)

HelperAppDialog.getNativeWindow() is unused after the changes in bug 1233440. Let's remove it.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/HelperAppDialog.js#38-46
Hello,
I am interested in working on this bug. Can you please assign it to me?
Regards,
Deepthi
Hi Deepthi. We usually assign a bug after a first patch has been uploaded. This patch is unclaimed so far.. so you can work on it. :)
Hello, I am new to the community. I tried to work on this bug. Hopefully it works.
Attachment #8702057 - Flags: review?(s.kaspari)
(In reply to Kartikey Agrawal from comment #3)
> Hello, I am new to the community. I tried to work on this bug. Hopefully it
> works.

Thank you for the patch! I'll assign the bug to you and will review the patch later. :)
Assignee: nobody → kartikey04.05
Status: NEW → ASSIGNED
Attachment #8702057 - Flags: review?(s.kaspari) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=567114cda107

I pushed your patch to try to be sure that it did not break anything (I don't expect it to break stuff). If everything's okay we can add the "checkin-needed" keyword to this bug and someone will land the patch for you. :)

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2fed3a17154e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
You need to log in before you can comment on or make changes to this bug.