1234131 - Remove unused method getNativeWindow() in HelperAppDialog.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

HelperAppDialog.getNativeWindow() is unused after the changes in bug 1233440. Let's remove it.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/HelperAppDialog.js#38-46

Comment 1

[Deepthi Venkitaramanan[:venkid]]

Hello,
I am interested in working on this bug. Can you please assign it to me?
Regards,
Deepthi

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Hi Deepthi. We usually assign a bug after a first patch has been uploaded. This patch is unclaimed so far.. so you can work on it. :)

Comment 3

[Kartikey Agrawal[:kartikey0303]]

Attachment: Removed the requested method getNativeWindow()

Hello, I am new to the community. I tried to work on this bug. Hopefully it works.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Kartikey Agrawal from comment #3)
> Hello, I am new to the community. I tried to work on this bug. Hopefully it
> works.

Thank you for the patch! I'll assign the bug to you and will review the patch later. :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=567114cda107

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=567114cda107

I pushed your patch to try to be sure that it did not break anything (I don't expect it to break stuff). If everything's okay we can add the "checkin-needed" keyword to this bug and someone will land the patch for you. :)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2fed3a17154e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2fed3a17154e