Closed
Bug 1233529
Opened 7 years ago
Closed 6 years ago
Intermittent TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_the_web_test.js | Homescreen - Pin the web Pinning a site from the browser context menu
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.6 S6 - 1/29
People
(Reporter: mikehenrty, Assigned: apastor)
References
Details
(Keywords: intermittent-failure, Whiteboard: [MJS][systemsfe])
Attachments
(3 files)
TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_the_web_test.js | Homescreen - Pin the web Pinning a site from the browser context menu Error: timeout exceeded! at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16) at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60) at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12) at Object.pinDialog (apps/system/test/marionette/lib/pinning_the_web.js:21:31) at Object.PinningTheWeb._clickPinContextMenu (apps/system/test/marionette/lib/pinning_the_web.js:119:43) at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:72:10) at Context.<anonymous> (apps/homescreen/test/marionette/pinning_the_web_test.js:54:13) at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31) at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15 at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)
Reporter | ||
Comment 1•7 years ago
|
||
disabled in master: https://github.com/mozilla-b2g/gaia/commit/af827aed4b3f8cb2e4e4434ea7d7ea96e24878bc
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → apastor
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8710468 [details] [review] [gaia] albertopq:1233529-pin-intermitent > mozilla-b2g:master This seems to help: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2afa4d8c842a5ffc0b2d0f91046fa5c7f07f1bef&selectedJob=3417122
Attachment #8710468 -
Flags: review?(mhenretty)
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8710468 [details] [review] [gaia] albertopq:1233529-pin-intermitent > mozilla-b2g:master I'm worried about this change, since the default timeout for this is currently 60000ms [1], so this is actually decreasing the timeout here (and I've seen this line in the pinning library failing on a number of tests with that timeout. If anything, I would say we should increase this timeout beyond 1 minute. 1.) https://github.com/mozilla-b2g/gaia/blob/9d8f052fe836bb83557c8a6c8d87b8fe1b066424/tests/jsmarionette/client/marionette-client/lib/marionette/client.js#L13
Attachment #8710468 -
Flags: review?(mhenretty)
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8710468 [details] [review] [gaia] albertopq:1233529-pin-intermitent > mozilla-b2g:master Yeah, you are right. I thought the timeout was 1 second. I increased it a little bit. It seems to help, but I think the last changes we did to the library (in another bug) helped this bug too. 100 green runs :)
Attachment #8710468 -
Flags: review?(mhenretty)
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 8710468 [details] [review] [gaia] albertopq:1233529-pin-intermitent > mozilla-b2g:master Ok, let's give it a try! Also, make sure not to land the testing-only changes :)
Attachment #8710468 -
Flags: review?(mhenretty) → review+
Assignee | ||
Comment 7•6 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/dc72acb44096f012b6df6ee12efa192c5adc1e9a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Target Milestone: --- → 2.6 S6 - 1/29
Reporter | ||
Comment 8•6 years ago
|
||
Alberto, this change ended up having no effect. The additional timeout you add is after you call this.pinDialog [1], which is a getter that does a waitForElement on the pinDialog selector with the normal timeout. You should change this to the selector rather than using the getter. Conversely, you can increase the waitForElement timeout in the getter itself. 1.) https://github.com/mozilla-b2g/gaia/commit/dc72acb44096f012b6df6ee12efa192c5adc1e9a#diff-f87c6634998bcca584f441fdda6dd5c2R121
Flags: needinfo?(apastor)
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
I'm going to carry over the r+, as is the same fix in the right place. Follow up: master: https://github.com/mozilla-b2g/gaia/commit/2107a9299ff50db25507a3ac455eebdbbed0da2e
Flags: needinfo?(apastor)
You need to log in
before you can comment on or make changes to this bug.
Description
•