Closed Bug 1233557 Opened 4 years ago Closed 4 years ago

Allow RGB8 to be renderable

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(2 files)

It's not guaranteed by spec, and we should deprecate it, but its use may be too entrenched to change at this point.

We should keep an eye out for drivers that don't allow this.
Attachment #8699629 - Flags: review?(jmuizelaar)
Depends on: webgl-tex-refactor
(In reply to Jeff Gilbert [:jgilbert] from comment #0)
> Created attachment 8699629 [details] [diff] [review]
> 0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch
> 
> It's not guaranteed by spec, and we should deprecate it, but its use may be
> too entrenched to change at this point.
> 
> We should keep an eye out for drivers that don't allow this.

Did we allow this before?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> (In reply to Jeff Gilbert [:jgilbert] from comment #0)
> > Created attachment 8699629 [details] [diff] [review]
> > 0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch
> > 
> > It's not guaranteed by spec, and we should deprecate it, but its use may be
> > too entrenched to change at this point.
> > 
> > We should keep an eye out for drivers that don't allow this.
> 
> Did we allow this before?

Yes.
Comment on attachment 8699629 [details] [diff] [review]
0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch

Review of attachment 8699629 [details] [diff] [review]:
-----------------------------------------------------------------

Worth adding a comment about we'd prefer not to allow this?
Attachment #8699629 - Flags: review?(jmuizelaar) → review+
See Also: → 1233047
Blocks: 1233569
Comment on attachment 8699629 [details] [diff] [review]
0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch

Approval Request Comment
[Feature/regressing bug #]: but webgl-tex-refactor
[User impact if declined]: Broken WebGL demos. (web-compat)
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8699629 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/40bdbd4eff2a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Attachment #8699629 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8699644 - Flags: review?(jmuizelaar) → review+
Depends on: 1286840
You need to log in before you can comment on or make changes to this bug.