1233557 - Allow RGB8 to be renderable

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch

It's not guaranteed by spec, and we should deprecate it, but its use may be too entrenched to change at this point.

We should keep an eye out for drivers that don't allow this.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Gilbert [:jgilbert] from comment #0)
> Created attachment 8699629 [details] [diff] [review]
> 0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch
> 
> It's not guaranteed by spec, and we should deprecate it, but its use may be
> too entrenched to change at this point.
> 
> We should keep an eye out for drivers that don't allow this.

Did we allow this before?

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> (In reply to Jeff Gilbert [:jgilbert] from comment #0)
> > Created attachment 8699629 [details] [diff] [review]
> > 0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch
> > 
> > It's not guaranteed by spec, and we should deprecate it, but its use may be
> > too entrenched to change at this point.
> > 
> > We should keep an eye out for drivers that don't allow this.
> 
> Did we allow this before?

Yes.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8699629 [details] [diff] [review]
0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch

Review of attachment 8699629 [details] [diff] [review]:
-----------------------------------------------------------------

Worth adding a comment about we'd prefer not to allow this?

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-Be-explicit-about-our-allowance-of-RGB8-renderabilit.patch

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8699629 [details] [diff] [review]
0001-Allow-RGB8-even-though-it-s-not-guaranteed.patch

Approval Request Comment
[Feature/regressing bug #]: but webgl-tex-refactor
[User impact if declined]: Broken WebGL demos. (web-compat)
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40bdbd4eff2a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40bdbd4eff2a

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/001ddf39af08