1233706 - Make error message more helpful if robocop test is run without robocop

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect, P5)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

If you are running a robocop test from the IDE and did not run "robocop --serve" the following exception is thrown:

> java.lang.RuntimeException: No log file specified!
> at org.mozilla.gecko.FennecNativeDriver.log(FennecNativeDriver.java:354)
> at org.mozilla.gecko.FennecNativeDriver.log(FennecNativeDriver.java:349)
> at org.mozilla.gecko.FennecNativeDriver.getFile(FennecNativeDriver.java:287)
> at org.mozilla.gecko.tests.BaseRobocopTest.setUp(BaseRobocopTest.java:154)
> at org.mozilla.gecko.tests.BaseTest.setUp(BaseTest.java:100)
> at org.mozilla.gecko.tests.ContentProviderTest.setUp(ContentProviderTest.java:229)
> at org.mozilla.gecko.tests.testDistribution.setUp(testDistribution.java:556)
> at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
> at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
> at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:529)
> at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1448)

It would be nice if we could make this a bit more helpful by printing something like "Are you running this test from an IDE? Did you forget to run robocop --serve"?

Comment 1

[Geoff Brown [:gbrown]]

Mass closing Firefox for Android :: Testing bugs with no progress in 2017.

If this bug is important to you, please re-open.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

I've encountered this issue today and after a quick search I got to this ticket which helped shed light on how to properly run instrumented Robocop tests.

It would be nice to avoid searching the Internet for this.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1233706 - Make error message more helpful for instrumented Robocop tests;

Review commit: https://reviewboard.mozilla.org/r/259610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259610/

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Updated instrumented Robocop error.png

I think this error message 
> No log file specified!
> (If you are running this test from an IDE don't forget to before run "robocop --serve")
is more descriptive and helpful regarding the issue.

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8995135 [details]
Bug 1233706 - Make error message more helpful for instrumented Robocop tests;

https://reviewboard.mozilla.org/r/259610/#review267412

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b025461ceed
Make error message more helpful for instrumented Robocop tests; r=jchen

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9b025461ceed