Clean up code for handling 'do-command' and 'copypaste-docommand'

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In BrowserElementChildPreload.js and BrowserElementParent.js, we add code to support 'copypaste-docommand' and 'do-command' to handle to copy/paste/cut operation from text_selection_dialog.js in Gaia. We need to clean it up since SelectionCarets and text_selection_dialog.js are removed in bug 1221459 and bug 1221462.

Also the test case at [1] might need to be revised.

[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/dom/browser-element/mochitest/browserElement_CopyPaste.js#92
(Assignee)

Updated

3 years ago
Assignee: nobody → tlin
(Assignee)

Comment 1

3 years ago
Created attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

Review commit: https://reviewboard.mozilla.org/r/29021/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29021/
Attachment #8701671 - Flags: review?(mtseng)
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

https://reviewboard.mozilla.org/r/29021/#review25839
Attachment #8701671 - Flags: review?(mtseng) → review+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29021/diff/1-2/
Attachment #8701671 - Flags: review?(bugs)
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

https://reviewboard.mozilla.org/r/29021/#review25915

Odd code. I wonder why we had two almost the same notifications and message types.
Attachment #8701671 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

3 years ago
Thank you for the review! That's why wee need to delete the obsolete code to avoid confusion :)
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=19064831&repo=mozilla-inbound
Flags: needinfo?(tlin)
(Assignee)

Comment 9

3 years ago
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29021/diff/1-2/
Attachment #8701671 - Attachment description: MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand' → MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
(Assignee)

Comment 10

3 years ago
Latest try (B2G ICS Emulator green!)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29a34873a6d4
Flags: needinfo?(tlin)

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5b36dc383731
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.