1234217 - UI should prevent the user that he's trying to close the tab while the wizard is running

Status: RESOLVED FIXED

(Firefox OS Graveyard :: B2gInstaller, defect)

Description

[Johan Lorenzo [:jlorenzo] - PTO - Back April 13th]

STR
1. Click on "Flash device"
2. Close the tab (by either Ctrl+W, clicking on the close button, quitting Firefox)

Expected results
Like on some website, a modal pop up should appear warning the user about the effects of closing this page. 

Actual results
No warning, the tab gets closed. This is harmful if the user didn't want to intentionally close the window.

Comment 1

[:gerard-majax]

While I agree, https://developer.mozilla.org/en-US/docs/Web/Events/beforeunload does not work in this case. Maybe because of "about:" ?

Comment 2

[Johan Lorenzo [:jlorenzo] - PTO - Back April 13th]

Attachment: b2g-installer PR

Discussed on IRC. We don't know what was different between your first attempt and this changeset. This one works on a default profile.

Comment 3

[:gerard-majax]

Comment on attachment 8706902 [details] [review]
b2g-installer PR

I cannot tell why I got this non working for several hours yesterday.

Comment 4

[Johan Lorenzo [:jlorenzo] - PTO - Back April 13th]

(In reply to Alexandre LISSY :gerard-majax from comment #3)
> I cannot tell why I got this non working for several hours yesterday.

Discussed offline: This PR has been deprecated because Alexandre thinks it's preferable to show the warning only when the Flashing modal is shown. Some other work is required before enabling this feature.

Comment 5

[:gerard-majax]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > I cannot tell why I got this non working for several hours yesterday.
> 
> Discussed offline: This PR has been deprecated because Alexandre thinks it's
> preferable to show the warning only when the Flashing modal is shown. Some
> other work is required before enabling this feature.

Risky time is the window during which we:
 - check device's compatibility
 - pull blobs
 - build new images
 - fastboot flash

Out of those steps, we should not mess with the user

Comment 6

[Johan Lorenzo [:jlorenzo] - PTO - Back April 13th]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> 
> Risky time is the window during which we:
>  - check device's compatibility
>  - pull blobs
>  - build new images
>  - fastboot flash
> 

I'd add the download part too. Firefox Desktop warns the user if they are some downloads happening when he tries to quit.

Then, I'd extend it to when the flashing modal window is shown.

Comment 7

[:gerard-majax]

yeah, that covers what I had in mind :)

Comment 8

[:gerard-majax]

Attachment: Prompt user to avoid unintentional risky tab close

Still some work needed but basics are here.

Comment 9

[:gerard-majax]

Attachment: Prompt user to avoid unintentional risky tab close

Comment 10

[:gerard-majax]

Attachment: Prompt user to avoid unintentional risky tab close

Now should be good :)

Comment 11

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bab6de0eb56

Comment 12

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #11)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bab6de0eb56

Green!

Comment 13

[Dale Harvey (:daleharvey)]

Comment on attachment 8707494 [details] [diff] [review]
Prompt user to avoid unintentional risky tab close

Sweet gave this a test and works well, cheers

Comment 14

[:gerard-majax]

Attachment: PR of the patch

Comment 15

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-installer/commit/9ee3963409b1f808914997950035697a7a4c7c2b