Closed
Bug 1238945
Opened 10 years ago
Closed 10 years ago
Be more lazy on message listeners to avoid ressources waste
Categories
(Firefox OS Graveyard :: B2gInstaller, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.6 S5 - 1/15
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(3 files, 2 obsolete files)
|
2.95 KB,
patch
|
Details | Diff | Splinter Review | |
|
8.20 KB,
patch
|
daleharvey
:
review+
|
Details | Diff | Splinter Review |
|
52 bytes,
text/x-github-pull-request
|
gerard-majax
:
review+
|
Details | Review |
If a user installs the addon on his day to day profile, we probably don't want to be constantly listening for imaging tools messages, but rather just when the about: page is active.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8706921 -
Flags: review?(dale)
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.6 S5 - 1/15
|
|
Assignee | |
Comment 2•10 years ago
|
||
Somehow, a solution making use of inner window ID does not work:
> B2G Installer: Doing ImagingTools.init() bootstrap.js:96
> [...]
> B2G Installer: All tools have been picked up. bootstrap.js:87
> B2G Installer: aTopic: inner-window-destroyed bootstrap.js:96
> B2G Installer: wId: 24 bootstrap.js:96
> B2G Installer: _windowID: 24 bootstrap.js:96
> B2G Installer: Doing ImagingTools.uninit()
That happens when loading about:b2g-installer
|
|
Assignee | |
Comment 3•10 years ago
|
||
With tests!
Attachment #8706921 -
Attachment is obsolete: true
Attachment #8706921 -
Flags: review?(dale)
Attachment #8707002 -
Flags: review?(dale)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8707002 -
Attachment is obsolete: true
Attachment #8707002 -
Flags: review?(dale)
Attachment #8707004 -
Flags: review?(dale)
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bab6de0eb56
Green!
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8707004 [details] [diff] [review]
ImagingTools should be more started/stopped at demand
Very nice, Cheers
Attachment #8707004 -
Flags: review?(dale) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Attachment #8709529 -
Flags: review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•