Closed Bug 1234223 Opened 4 years ago Closed 4 years ago

Undefined "this.longDayName" used in calDateTimeFormatter.formatDateLong

Categories

(Calendar :: Internal Components, defect)

Lightning 4.4
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tatsuya.sugi, Assigned: MakeMyDay)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151216175450

Steps to reproduce:

calendar-js\calDateFormatter.js # formatDateLong
Line107-108 :
      if (!longDate.includes(this.dayName(aDate.weekday)) &&
          !longDate.includes(this.longDayName(aDate.weekday))) {

But, "longDayName" seems to be undefined. So this method call failed and then the entire "formatDateLong" method call fails. 


Actual results:

As the side effect of this issue, the column title in daily-view or weekly-view is displayed as "<date> <month> <dayName>" order even in Japanese locale.  


Expected results:

The column title in daily-view or weekly-view should be formatted as "<month> <date> <dayName>" order in Japanese locale.

Change the line 107-108 as
//      if (!longDate.includes(this.dayName(aDate.weekday)) &&
//          !longDate.includes(this.longDayName(aDate.weekday))) {
      if (!longDate.includes(this.dayName(aDate.weekday))) {
Then, the column title in daily-view or weekly-view is formatted as expected. Or, "longDayName" should be implemented.
Blocks: 1167939
Source code in question was added with Bug 1167939 in Lightning 4.4.

http://mxr.mozilla.org/comm-central/source/calendar/base/public/calIDateTimeFormatter.idl#155 contains only dayName() and shortDayName(), maybe those two methods were supposed to be called instead.
Version: Lightning 4.8 → Lightning 4.4
This patch should take care.
Assignee: nobody → makemyday
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8701163 - Flags: review?(philipp)
Attachment #8701163 - Flags: approval-calendar-aurora?(philipp)
Blocks: ltn47
Attachment #8701163 - Flags: review?(philipp)
Attachment #8701163 - Flags: review+
Attachment #8701163 - Flags: approval-calendar-aurora?(philipp)
Attachment #8701163 - Flags: approval-calendar-aurora+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4f316f02644d4780e8bb2fd6bd53f59ba19910b6
Bug 1234223 - Undefined "this.longDayName" used in calDateTimeFormatter.formatDateLong ;r=philipp
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.8
Whiteboard: [checkin-needed comm-aurora]
Keywords: checkin-needed
Backported to releases/comm-aurora changeset 4236037e0175
Keywords: checkin-needed
Target Milestone: 4.8 → 4.7
Whiteboard: [checkin-needed comm-aurora]
You need to log in before you can comment on or make changes to this bug.