1234223 - Undefined "this.longDayName" used in calDateTimeFormatter.formatDateLong

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[tatsuya.sugi]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151216175450

Steps to reproduce:

calendar-js\calDateFormatter.js # formatDateLong
Line107-108 :
      if (!longDate.includes(this.dayName(aDate.weekday)) &&
          !longDate.includes(this.longDayName(aDate.weekday))) {

But, "longDayName" seems to be undefined. So this method call failed and then the entire "formatDateLong" method call fails. 


Actual results:

As the side effect of this issue, the column title in daily-view or weekly-view is displayed as "<date> <month> <dayName>" order even in Japanese locale.  


Expected results:

The column title in daily-view or weekly-view should be formatted as "<month> <date> <dayName>" order in Japanese locale.

Change the line 107-108 as
//      if (!longDate.includes(this.dayName(aDate.weekday)) &&
//          !longDate.includes(this.longDayName(aDate.weekday))) {
      if (!longDate.includes(this.dayName(aDate.weekday))) {
Then, the column title in daily-view or weekly-view is formatted as expected. Or, "longDayName" should be implemented.

Comment 1

[Stefan Sitter [:ssitter]]

Source code in question was added with Bug 1167939 in Lightning 4.4.

http://mxr.mozilla.org/comm-central/source/calendar/base/public/calIDateTimeFormatter.idl#155 contains only dayName() and shortDayName(), maybe those two methods were supposed to be called instead.

Comment 2

[[:MakeMyDay]]

Attachment: FixCalDateTimeFormatter-V1.diff

This patch should take care.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/4f316f02644d4780e8bb2fd6bd53f59ba19910b6
Bug 1234223 - Undefined "this.longDayName" used in calDateTimeFormatter.formatDateLong ;r=philipp

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 4236037e0175