1234366 - Convert netwerk/test/unit/test_spdy.js to use asyncOpen2

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Initially that testfile was already converted to use AsyncOpen2 within Bug 1233760. But caused problems on inbound and so I backed it out again. When running locally I realized the test doesn't even finish successfully without asyncOpen2:

0:01.02 TEST_STATUS: Thread-1 testOnStopRequest PASS [testOnStopRequest : 64] true == true
0:01.03 TEST_STATUS: Thread-1 testOnStopRequest FAIL [testOnStopRequest : 65] false == true
/home/ckerschb/moz/mc-obj-dbg/_tests/xpcshell/netwerk/test/unit/test_spdy.js:testOnStopRequest:65
/home/ckerschb/moz/mc/testing/xpcshell/head.js:_do_main:208
/home/ckerschb/moz/mc/testing/xpcshell/head.js:_execute_test:535

The error I receive locally is the error I received on inbound with the patch applied. Not sure what's going on. Pat, or Nick could any of you take a look?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1234366_asyncopen2_netwerk_test_spdy.patch

Already got an r+ for that patch from Patrick within Bug 1233760.

Comment 3

[Patrick McManus [:mcmanus]]

are your local problems related to not having the node server running? (typically on linux 64 used to make it work)

in any event I can reproduce the problem (both pass and fail with the patch) and will try and puzzle it out

Comment 4

[Patrick McManus [:mcmanus]]

it fails because the second argument of asyncopen (the channel itself in the push cases) is passed to onDataAvailable and is used on line 138 to check the uri

Comment 5

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34719cf84117

Comment 6

[Patrick McManus [:mcmanus]]

Attachment: Convert netwerk/test/unit/test_spdy.js to use asyncOpen2

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8701632 [details] [diff] [review]
Convert netwerk/test/unit/test_spdy.js to use asyncOpen2

Review of attachment 8701632 [details] [diff] [review]:
-----------------------------------------------------------------

Ah I see, thanks Pat.

Comment 8

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79e7505bce80ff259d5540c0b07bac7e7f25935d
Bug 1234366 - Convert netwerk/test/unit/test_spdy.js to use asyncOpen2 r=ckerschb

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79e7505bce80