Closed Bug 1193558 Opened 5 years ago Closed 4 years ago

[tracking bug] Use channel.asyncOpen2 in netwerk/test

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

(Keywords: meta, Whiteboard: [domsecurity-meta])

No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Since there are almost 200 callsites for netwerk/test. I think it makes sense to make this bug a tracking bug for converting all the callsites within netwerk/test.
Status: NEW → ASSIGNED
Summary: Use channel.ascynOpen2 in netwerk/test → [tracking bug] Use channel.ascynOpen2 in netwerk/test
Hey Pat, asyncOpen2() only takes one argument whereas asyncOpen() takes two arguments. Surely we would like to have test coverage for asyncOpen() as long as possible. However, there are many tests within [1] that pass 'null' as the second argument. Are you fine with us converting those over to use AsyncOpen2() or would you rather still wait and have all other converted to use asyncOpen2() first before we touch network tests?

[1] http://mxr.mozilla.org/mozilla-central/search?string=.asyncOpen%28&find=netwerk/test/
Flags: needinfo?(mcmanus)
I would be very pleased to have the conversion start asap - leaving at least one asyncOpen() 2 argument test around until the end ought to be sufficient. Thanks!
Flags: needinfo?(mcmanus)
Depends on: 1232422
Depends on: 1232567
Depends on: 1232899
Depends on: 1233760
Depends on: 1233843
Depends on: 1234366
Depends on: 1234368
Depends on: 1234369
Depends on: 1234591
Depends on: 1234596
Depends on: 1234757
Summary: [tracking bug] Use channel.ascynOpen2 in netwerk/test → [tracking bug] Use channel.asyncOpen2 in netwerk/test
Depends on: 1240193
Depends on: 1246220
Depends on: 1246725
Depends on: 1246736
No longer depends on: 1246736
We are almost done with converting those callsites - unassigning myself from this tracking bug.
Assignee: mozilla → nobody
Status: ASSIGNED → NEW
if its unassigned its probably not useful to keep open.. agree? (I dislike tracking bugs. tags are great.)
There are two more bugs which need to land but are blocked by other bugs. If you prefer, I'll keep the bug assigned to myself for now. For the future, I agree, let's use tags rather than tracking bugs.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Depends on: 1254299
Depends on: 1254303
No longer depends on: 1246725
No longer depends on: 1254303
No longer depends on: 1254299
Keywords: meta
Whiteboard: [domsecurity-meta]
Depends on: 1273458
Depends on: 1278641
done and done!
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.