1193558 - [tracking bug] Use channel.asyncOpen2 in netwerk/test

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Since there are almost 200 callsites for netwerk/test. I think it makes sense to make this bug a tracking bug for converting all the callsites within netwerk/test.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Hey Pat, asyncOpen2() only takes one argument whereas asyncOpen() takes two arguments. Surely we would like to have test coverage for asyncOpen() as long as possible. However, there are many tests within [1] that pass 'null' as the second argument. Are you fine with us converting those over to use AsyncOpen2() or would you rather still wait and have all other converted to use asyncOpen2() first before we touch network tests?

[1] http://mxr.mozilla.org/mozilla-central/search?string=.asyncOpen%28&find=netwerk/test/

Comment 3

[Patrick McManus [:mcmanus]]

I would be very pleased to have the conversion start asap - leaving at least one asyncOpen() 2 argument test around until the end ought to be sufficient. Thanks!

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

We are almost done with converting those callsites - unassigning myself from this tracking bug.

Comment 5

[Patrick McManus [:mcmanus]]

if its unassigned its probably not useful to keep open.. agree? (I dislike tracking bugs. tags are great.)

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

There are two more bugs which need to land but are blocked by other bugs. If you prefer, I'll keep the bug assigned to myself for now. For the future, I agree, let's use tags rather than tracking bugs.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

done and done!