./mach mercurial-setup did not "brew install watchman" for me

RESOLVED FIXED

Status

Developer Services
Mercurial: configwizard
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Jesse Ruderman, Assigned: gps)

Tracking

Trunk

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8700830 [details]
output from when I ran ./mach mercurial-setup

Re-running "./mach mercurial-setup" (@ mozilla-central a8acaa9868df) put a watchman thing in my hg config, but did not run "brew install watchman", so I got a warning the next time I ran hg diff:

> warning: watchman unavailable: ('"watchman" executable not in PATH (%s)', OSError(2, 'No such file or directory'))

Manually running "brew install watchman" fixed this problem.

There's code in bug 1231989 to do both, but maybe the brew part doesn't run every time?
Flags: needinfo?(gps)
(Assignee)

Comment 1

2 years ago
Did you run `mach bootstrap`?

(The fact we have multiple commands for configuring your system is kind of unfortunate - they really do need to be consolidated.)
Flags: needinfo?(gps)
(Reporter)

Comment 2

2 years ago
Not recently. Am I supposed to run that one frequently too?
(Assignee)

Comment 3

2 years ago
(In reply to Jesse Ruderman from comment #2)
> Not recently. Am I supposed to run that one frequently too?

It shouldn't hurt.
I am facing the same issue. I did run |mach bootstrap| today, no changes!
Any fix for this?
Flags: needinfo?(gps)
(Assignee)

Comment 5

2 years ago
`mach bootstrap` installs watchman via Homebrew and MacPorts as of bug 1231989 (landed in December). That should "just work."

I guess the bug here is `mach mercurial-setup` needs to have something better to say when `watchman` isn't available.
Flags: needinfo?(gps)
(Assignee)

Updated

2 years ago
status-firefox46: affected → ---
Component: mach → Mercurial: configwizard
Product: Core → Developer Services

Comment 6

a year ago
I'm on Ubuntu. I run bootstrap and mercurial-setup but I still had no luck:
armenzg@armenzg-thinkpad:~/repos/firefox$ hg id
warning: Watchman unavailable: ('"watchman" executable not in PATH (%s)', OSError(2, 'No such file or directory'))

I see watchman checkouts on my disk:
armenzg@armenzg-thinkpad:~$ find . -type d -name watchman
./.mozbuild/hgwatchman/.hg/store/data/watchman
./dist/hgwatchman/.hg/store/data/watchman

Should I follow the installation steps in here?
https://facebook.github.io/watchman/docs/install.html#installing-from-source
(Assignee)

Comment 7

a year ago
Yes, you'll need to install watchman from source on Linux (at least on distros that don't have a watchman package yet).

Also, if you are running a modern Mercurial, hgwatchman has been integrated into the distribution as the "fsmonitor" extension. You can delete hgwatchman from your machine if using fsmonitor.
(Assignee)

Updated

a year ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
(Assignee)

Comment 8

a year ago
Created attachment 8769298 [details]
configwizard: print warning when watchman isn't installed (bug 1234394);

Review commit: https://reviewboard.mozilla.org/r/63268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63268/
Attachment #8769298 - Flags: review?(smacleod)

Comment 9

a year ago
I saw the fsmonitor extension getting installed after I upgraded to a newer Mercurial.

What should I do about this hgwatchman under .mozbuild?
Is that a leftover failed installation attempt from mercurial-setup?
(Assignee)

Comment 10

a year ago
You can safely delete hgwatchman from .mozbuild after using fsmonitor. If you are annoyed by it being orphaned, file a follow-up bug to have the Mercurial configwizard extension nuke it.
Comment on attachment 8769298 [details]
configwizard: print warning when watchman isn't installed (bug 1234394);

https://reviewboard.mozilla.org/r/63268/#review60740
Attachment #8769298 - Flags: review?(smacleod) → review+

Comment 12

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/438d0657d78f
configwizard: print warning when watchman isn't installed ; r=smacleod
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.