1234648 - add a toggle to show dupes in groups

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Cameron Dawson [:camd]]

We added the group counts to cut down on the number of shown elements.  But then we decided to show dupes (because they are likely retriggers) when present within the same group in bug 1197258.

However, this causes a speed hit for the page and perhaps many people don't want/care about the retriggers.

Perhaps a nice compromise would be to add a(nother) button on the toolbar to toggle that.  Basically "Show Dupes" which would give the view we have after bug 1197258, whereas the default would be to hide them in the counts as we did prior to that bug.

Comment 1

[Cameron Dawson [:camd]]

Adding most of the cc list from bug 1197258 for opinions.  Would this just be further hiding things behind undiscoverable magic buttons and lead to obfuscation and "obfrustration" ?  :)

Seems like this would make everyone sing with joy, but perhaps that's just the holiday spirit hitting me...

Comment 2

[William Lachance (:wlach)]

I'm not sure about this, it sounds like you're trying to work around slow rendering performance. If that's the real issue, why not look at fixing bug 1164266? I think that should be a relatively quick win, and will probably make more of a difference than this would (since it would improve the rendering of every job row, not just those with retriggers).

Comment 3

[Ed Morley [:emorley]]

Could you give an example of a page where showing retriggers is causing perf issues?

It may be these aren't retriggers after all, but jobs that are not being submitted in a unique enough way - or perhaps repos where automation is being daft and triggering identical nightlies day after day, when no new commits have landed etc.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central

Comment 5

[Ed Morley [:emorley]]

Ah so those are because both the standard build and nightly builds are being reported the same. This is a long standing issue, but I still think we should fix the root cause.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Plus any rev that runs 2 nightly builds ends up with a pile of update tests that are unhidden, which adds thousands of jobs to the UI.

Comment 7

[Cameron Dawson [:camd]]

While perf is an issue, it is also page noise.  iirc, that was the other 1/2 of why Ryan proposed this.  Collapsing the dupes by default and toggling them on/off would help with that, too.

Comment 8

[Cameron Dawson [:camd]]

Here's where we decide whether to collapse a job or show it because there are multiple

https://github.com/mozilla/treeherder/blob/183effad0b0cadaa19a9701f071430feced205b7/ui/js/directives/treeherder/clonejobs.js#L328-L328

and here's an example on prod of some jobs that are showing because they're dups: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=38892fd53242c6e452ed964e49410aaee1e935f2&filter-searchStr=android%206.0

If you point your local instance at production data and use those url params, you should be able to play with it.

Comment 9

[GitHub Autolander Bot]

Attachment: [treeherder] kkrivera:Bug-1234648 > mozilla:master

Comment 10

[Kris Rivera]

Pending PR
https://github.com/mozilla/treeherder/pull/1918

Comment 11

[Cameron Dawson [:camd]]

Kris: are you able to assign me as a reviewer for your PRs?  That'd really help with visibility since my Bugzilla queue is pretty bright-red and in my face most of the time.  :)  If you could assign it as Review ? and my email, that'd be awesome.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Cameron Dawson [:camd] from comment #11)
> Kris: are you able to assign me as a reviewer for your PRs?  That'd really
> help with visibility since my Bugzilla queue is pretty bright-red and in my
> face most of the time.  :)  If you could assign it as Review ? and my email,
> that'd be awesome.

If you can't assign reviewers, follow the steps in https://bugzilla.mozilla.org/page.cgi?id=get_permissions.html for the "editbugs" permissions, and it should get sorted out pretty quickly.

Comment 13

[Kris Rivera]

(In reply to Wes Kocher (:KWierso) from comment #12)
> (In reply to Cameron Dawson [:camd] from comment #11)
> > Kris: are you able to assign me as a reviewer for your PRs?  That'd really
> > help with visibility since my Bugzilla queue is pretty bright-red and in my
> > face most of the time.  :)  If you could assign it as Review ? and my email,
> > that'd be awesome.
> 
> If you can't assign reviewers, follow the steps in
> https://bugzilla.mozilla.org/page.cgi?id=get_permissions.html for the
> "editbugs" permissions, and it should get sorted out pretty quickly.

Thank you Wes, I just signed on and attempted to see how I would do this, but it looks like I require elevated permissions. Thank you

Comment 14

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ddd5512c116f9ec470f1fb496f7837c8961a57c7
Bug 1234648 - added a new button to toggle duplicate jobs being shown inside of groups (#1918)