1234654 - WebSpeech stops working

Status: RESOLVED INVALID

(Core :: Web Speech, defect)

Description

[KOLANICH]

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20151222030207

Steps to reproduce:

When incorrect or missing SAPI language ID is provided, for example
speechSynthesis.speak(new SpeechSynthesisUtterance('<voice required="Language=ololo">ololo</voice>'))


Actual results:

WebSpeech stops working


Expected results:

it mustn't

Comment 1

[Eitan Isaacson [:eeejay]]

I don't think we should support that <voice> markup in that example. Maybe we should escape it?

Comment 2

[KOLANICH]

>I don't think we should support that <voice> markup in that example. Maybe we should escape it?
No. WebSpeech should allow providing SSML which is xml too. If you worry about using SAPI5 instead of SSML, see https://bugzilla.mozilla.org/show_bug.cgi?id=835156

Comment 3

[KOLANICH]

And WebSpeech shouldn't stop working, the programs like balabolka don't stop working after provision of incorrect sapi xml.

Maybe you should sanitize WS to plain text until https://bugzilla.mozilla.org/show_bug.cgi?id=835156 is fixed, there can be some rce in sapi and we don't want users' security be compromised.

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Eitan Isaacson [:eeejay] from comment #1)
> I don't think we should support that <voice> markup in that example. Maybe
> we should escape it?

Sure.  Speak method of SAPI API use XML format.  So we should escape it.

Comment 5

[Makoto Kato [:m_kato]]

KOLANICH, our implementation doesn't support SAPI XML now. so if using Firefox 49, it will speak as text.

Could you test this on Firefox 49?

Comment 6

[KOLANICH]

Sorry, but I have migrated from Windows to Linux.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

no activity for the last 7 years, closing