Closed Bug 1234802 Opened 6 years ago Closed 6 years ago

Create hotfix addon to update media.fragmented-mp4.gmp.enabled to false in Firefox 43

Categories

(Firefox :: General, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox43 --- affected

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

We need to change this pref in 43 due to problems described in bug 1233429.
Attached patch bug-1234802.diffSplinter Review
Sorry for the mass review request, with all these pto... :)
Attachment #8701431 - Flags: review?(robert.strong.bugs)
Attachment #8701431 - Flags: review?(jorge)
Attachment #8701431 - Flags: review?(felipc)
Assignee: nobody → sledru
Blocks: 1234807
Comment on attachment 8701431 [details] [diff] [review]
bug-1234802.diff

Review of attachment 8701431 [details] [diff] [review]:
-----------------------------------------------------------------

Code okay to me.

::: v20151223.01/bootstrap.js
@@ +25,5 @@
>      return;
>    }
>  
>    try {
>      // Update the HTTP authentication from sub-resources value

Nit: change or remove this comment.
Attachment #8701431 - Flags: review?(jorge) → review+
(In reply to Jorge Villalobos [:jorgev] from comment #2)
> Code okay to me.

Code *looks* okay to me. Blame the holidays :P
Pushed, thanks!
https://hg.mozilla.org/releases/firefox-hotfixes/rev/efbd17ffd244
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8701431 - Flags: review?(robert.strong.bugs)
Comment on attachment 8701431 [details] [diff] [review]
bug-1234802.diff

Reminder to file a follow-up bug to rename the pref :)
Attachment #8701431 - Flags: review?(felipc)
(In reply to :Felipe Gomes (away Dec 19 - Jan 2, use needinfo!) from comment #5)
> Comment on attachment 8701431 [details] [diff] [review]
> bug-1234802.diff
> 
> Reminder to file a follow-up bug to rename the pref :)

The pref is already renamed in 44.
You need to log in before you can comment on or make changes to this bug.