1234802 - Create hotfix addon to update media.fragmented-mp4.gmp.enabled to false in Firefox 43

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

We need to change this pref in 43 due to problems described in bug 1233429.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug-1234802.diff

Sorry for the mass review request, with all these pto... :)

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Comment on attachment 8701431 [details] [diff] [review]
bug-1234802.diff

Review of attachment 8701431 [details] [diff] [review]:
-----------------------------------------------------------------

Code okay to me.

::: v20151223.01/bootstrap.js
@@ +25,5 @@
>      return;
>    }
>  
>    try {
>      // Update the HTTP authentication from sub-resources value

Nit: change or remove this comment.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Jorge Villalobos [:jorgev] from comment #2)
> Code okay to me.

Code *looks* okay to me. Blame the holidays :P

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Pushed, thanks!
https://hg.mozilla.org/releases/firefox-hotfixes/rev/efbd17ffd244

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8701431 [details] [diff] [review]
bug-1234802.diff

Reminder to file a follow-up bug to rename the pref :)

Comment 6

[Mike Hommey [:glandium]]

(In reply to :Felipe Gomes (away Dec 19 - Jan 2, use needinfo!) from comment #5)
> Comment on attachment 8701431 [details] [diff] [review]
> bug-1234802.diff
> 
> Reminder to file a follow-up bug to rename the pref :)

The pref is already renamed in 44.