Closed
Bug 1235128
Opened 9 years ago
Closed 9 years ago
[TV][2.5] System banner supports icon and title
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect, P2)
Tracking
(feature-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick])
Attachments
(5 files, 1 obsolete file)
Old system banner.png
According to Visual Spec 3.3, system banner has to show up with a left icon as well as a title.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
||
Updated•9 years ago
|
Blocks: TV_Marketplace_2.5
feature-b2g: --- → 2.5+
|
|
||
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-cherry-pick]
|
|
||
Updated•9 years ago
|
Priority: -- → P2
Target Milestone: --- → 2.6 S4 - 1/1
|
||
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8703122 [details] [review]
[gaia] rickychien:extendSystemBanner > mozilla-b2g:master
Hey Luke, happy new year!
Attachment #8703122 -
Flags: review?(lchang)
|
|
Assignee | |
Comment 6•9 years ago
|
||
|
|
Assignee | |
Comment 7•9 years ago
|
||
Attachment #8703244 -
Attachment is obsolete: true
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8703122 [details] [review]
[gaia] rickychien:extendSystemBanner > mozilla-b2g:master
Nice work! Don't forget to sync your modification with your another pull request of "smart-banner".
Thanks.
Attachment #8703122 -
Flags: review?(lchang) → review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
Landed in gaia master:
https://github.com/mozilla-b2g/gaia/commit/0d79de590f319619cd028a813f08f267e596d4a0
Landed in smart-components:
https://github.com/smart-components/smart-banner/commit/77486577258d1258e32a6818e7db84f7f9055c15
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•9 years ago
|
||
Comment on attachment 8703122 [details] [review]
[gaia] rickychien:extendSystemBanner > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature of bug 1204762
[User impact] if declined: feature request by partner
[Testing completed]: manual verified on local
[Risk to taking this patch] (and alternatives if risky): medium
[String changes made]:
added-to-apps
deleted-from-apps
press-option-hint
Attachment #8703122 -
Flags: approval-gaia-v2.5?
|
|
||
Updated•9 years ago
|
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
|
|
||
Comment 11•9 years ago
|
||
Comment on attachment 8703122 [details] [review]
[gaia] rickychien:extendSystemBanner > mozilla-b2g:master
Approved for TV 2.5
Attachment #8703122 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 12•9 years ago
|
||
|
||
Comment 13•9 years ago
|
||
This issue is verified on v2.5 and v2.6 latest build.
[Build Info]
2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08
gecko:
https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26
2.5 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•