1235411 - IsCallerChrome crash in HTMLMediaElement::Observe

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

See https://crash-stats.mozilla.com/report/index/9bde1061-c782-4605-84e6-319812151224 and similar.

I think we can just remove that check now that we have WebIDL.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Remove IsCallerChrome check in HTMLMediaElement::Observe. v1

Comment 2

[Bobby Holley (:bholley)]

This was added in bug 605264, FWIW.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8702321 [details] [diff] [review]
Remove IsCallerChrome check in HTMLMediaElement::Observe. v1

Approval Request Comment
[Feature/regressing bug #]: bug 1072150
[User impact if declined]: Crashes on Aurora/Nightly, misleading telemetry on Beta.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: Basically no risk - just removing an unnecessary early-return. 
[String/UUID change made/needed]: None

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b79d479b028

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b79d479b028

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8702321 [details] [diff] [review]
Remove IsCallerChrome check in HTMLMediaElement::Observe. v1

Fix a crash, taking it.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/54ffb191d00d

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40ca4cb65ff6

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/40ca4cb65ff6