1235457 - Create ThreadSafeDevToolsUtils for the utilities that can be used in workers

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This commit adds the ThreadSafeDevToolsUtils module for utilities that are
guaranteed to work off the main thread. It also makes DevToolsUtils re-export
the thread-safe utilities. This is similar to ChromeUtils and
ThreadSafeChromeUtils webidl interfaces.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Create ThreadSafeDevToolsUtils for the utilities that can be used in workers

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Motivation behind this is that I want to start using immutableUpdate inside devtools/shared/heapsnapshot/* so it has to go into devtools/shared/* (it is currently in devtools/client/memory) and the logical place to put it is DevToolsUtils however that has a bunch of stuff that doesn't work off-main-thread.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8702400 [details] [diff] [review]
Create ThreadSafeDevToolsUtils for the utilities that can be used in workers

Review of attachment 8702400 [details] [diff] [review]:
-----------------------------------------------------------------

I was going to express some concerns of the naming and separation (where any pure function would have to be imported via ThreadSafe[...]), but then saw that we also export the thread safe utils in normal DevToolsUtils which put at ease any concerns I had.

Should mention this at the next meeting so others know it's aware -- we should have some tests for these at some point..

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Create ThreadSafeDevToolsUtils for the utilities that can be used in workers

Rebase.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=053269714c94

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/63227efdffef

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/63227efdffef

Comment 8

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected