1235458 - Move as many utilities as we can from DevToolsUtils.js to ThreadSafeDevToolsUtils.js

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

So we can use them in workers easily and reliably.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Move a bunch of utilities from DevToolsUtils to ThreadSafeDevToolsUtils

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20745dda51bb

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The ones I'd like to most move over, I'm not sure we can: assert/reallyAssert and reportException. These currently rely on dump and Cu.reportError. Cu is not available in workers and I have no idea whether or not dump is.

Looking into the viability of using console.error() instead.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Looks like both dump() and console.error() work great in workers! \o/

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

But we still can't get assert because it relies on AppConstants :(

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Move a bunch of utilities from DevToolsUtils to ThreadSafeDevToolsUtils

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5ec81791b68

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Move a bunch of utilities from DevToolsUtils to ThreadSafeDevToolsUtils

Fixes for the failures from the try push.

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f54851ba101

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a80761b3a130

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a80761b3a130

Comment 12

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected