Closed Bug 1235510 Opened 8 years ago Closed 8 years ago

Remove obsolete robocop tests for SelectionHandler routines

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: capella, Assigned: capella)

References

Details

Attachments

(1 file)

Now that we've defaulted m-c to the new AccessibleCarets and the mobile/Gecko ActionBarHandler, we can remove from the test infra the obsolete robocop tests:

testSelectionHandler, testInputSelections, and testTextareaSelections
   (all .html, .java, robocop.ini bits, etc)

and SelectionUtils.js
Blocks: gecko-carets
Attached patch bug1235510.diffSplinter Review
Feel free to correct me here ... the (somewhat in-flight) docs here [0] show :jchen as backup for Text Selection decisions, so I thought this an appropriate, and fairly simple approval request.

The robocop.ini bits were already removed [1], so the rest seems pretty safe to lose.


[0] https://docs.google.com/spreadsheets/d/10i30CFUPJM7snz0xX3czFJeBh2tNwjwjtI409DQw3x0/edit?pref=2&pli=1#gid=1963541658
[1] https://hg.mozilla.org/mozilla-central/diff/65b8c89ff1b7/mobile/android/tests/browser/robocop/robocop.ini
Attachment #8714040 - Flags: review?(nchen)
Attachment #8714040 - Flags: review?(nchen) → review+
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3b154a6f2848
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: