Closed
Bug 1235559
Opened 8 years ago
Closed 8 years ago
|mach android-emulator| looks for the wrong file names on Windows
Categories
(Testing :: General, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
Details
Attachments
(1 file)
1.29 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
The |mach android-emulator| command looks for the existence of files without the ".exe" suffix on Windows. For this reason, it will not ever be able to find them automatically. A trivial fix would be to append the ".exe" suffix on Windows just before [1], if the suffix isn't there already. [0] - https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/testing/mozbase/mozrunner/mozrunner/devices/android_device.py#236,289,318 [1] - https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/testing/mozbase/mozrunner/mozrunner/devices/android_device.py#585
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Attachment #8702574 -
Flags: review?(gbrown)
Comment 2•8 years ago
|
||
Comment on attachment 8702574 [details] [diff] [review] bug123559.patch I originally neglected Windows, reasoning that the emulator would be of little use there as long as Firefox for Android builds were not supported there. From irc, I see that you have found a use! (Building on Linux VM, testing on Windows - good for you!) I don't have a Windows environment handy, but if there's anything else needed for Windows and I can be of help, give me a shout.
Attachment #8702574 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2f14aeae6e06a397d48f80f76608843a099771b7 Bug 1235559 - |mach android-emulator| looks for the wrong file names on Windows. r=gbrown
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2f14aeae6e06
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•