Closed Bug 12356 Opened 26 years ago Closed 25 years ago

[Menus] Key events are not being properly consumed

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Other
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: hyatt, Assigned: saari)

References

Details

The menu bar is not properly consuming key presses, so that they are leaking through to frames.
Status: NEW → ASSIGNED
Target Milestone: M11
Blocks: 12673
Blocks: 12670
My hands have deteriorated to the point where I can no longer type. I need help. If you think you can fix this bug on your own, please take it away from me. If you'd like to volunteer to be my hands for a specific bug, then I'll be happy to come up to your cube and sit with you and fix the bug (assuming you have the patience for that).
How can I see if this is still happening? Who else can we CC on this?
The nsMenuBarListener should be consuming events in the same way that the nsXULKeyListener is, but only when the menu bar listener is active. It is not doing this right now.
adding saari to cc list Chris--were you going to fix this (with hyatt's help)?
Yeah I can fix this
Blocks: 15693
Assignee: hyatt → saari
Status: ASSIGNED → NEW
reassigning to saari
mass-moving most m11 bugs to m12
Mass-moving non-PDT+ bugs to M13
spam: changing qa contact from ckritzer -> paulmac for xul bugs
Guess what? Key events are being properly consumed by the key listeners, but events always go to the frame regardless. joki, hyatt and myself have talked about this... joki, hyatt, is this invalid or were we actually going to change this in the future?
We are not going to change the fact that the events are sent to the frames. However I don't think that makes this bug invalid since the frame code in question needs to start looking at the event status and deciding whether to fire appropriately.
I made ender's event listener listen to the stop dispatch flag. Closing this bug.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
verified
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: paulmac → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.