Closed Bug 1235602 Opened 8 years ago Closed 8 years ago

"Preview of (tab?.webView?.accessibilityLabel)" string comment needs improvement

Categories

(Firefox for iOS :: Theme & Visual Design, defect)

Product:
Firefox for iOS
Component:
Theme & Visual Design
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: stef, Assigned: flod)

References

Details

https://github.com/mozilla/firefox-ios/commit/3510da787ec8a525bf4b85860e016a9d5aa130d2#diff-6375095665cccea3972c17e340fad2cdR91

Reading the string comment I have no idea what "tab?.webView?.accessibilityLabel" in it is supposed to be - is it error or will it be replaced and shouldn't be translated?
Blocks: 1242542
Blocks: 1256395
Blocks: 1264283
Blocks: 1277326
String is now "Preview of %@"
https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/TabPeekViewController.swift#L94
Assignee: nobody → francesco.lodolo
Comments updated as part of 
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.