1235681 - Add NSIS 3.0b3 to MozillaBuild

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Robert Strong (they/them - no direct email)]

It provides some DLL preloading capabilities

Comment 1

[Ryan VanderMeulen [:RyanVM]]

If we do this, it'd be great to get the in-tree parts backported to 45 so we're not stuck supporting 3.0b1 for an entire ESR cycle as well.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Rob is going to work on the configure.in changes for 3.0b3. I'll take care of the MozillaBuild patches.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: add NSIS 3.0b3 to MozillaBuild

Already looking forward to when ESR38 goes EOL and we can drop support for 2.46u and 3.0b1.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8703765 [details] [diff] [review]
add NSIS 3.0b3 to MozillaBuild

Looks good though I haven't tested this yet. I'll try to do so today.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Here's a test build for you to try :)
https://people.mozilla.org/~rvandermeulen/MozillaBuildSetup2.2.0pre2.exe (77.5MB)
SHA-256: 9ed8e82bd722d4c30224ec5820d0fb508967ceabd9fb191d237a2dec414a8d81

Comment 6

[Robert Strong (they/them - no direct email)]

Thank you!

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #4)
> Comment on attachment 8703765 [details] [diff] [review]
> add NSIS 3.0b3 to MozillaBuild
> 
> Looks good though I haven't tested this yet. I'll try to do so today.
Compiles fine. I'll verify functionality tomorrow.

Comment 7

[Robert Strong (they/them - no direct email)]

Functionality looks good. Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-build/rev/a3e3ad49f770