1235845 - Pocket icon of toolbar button is broken on windows and osx HiDPI

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[arni2033]

Attachment: 2015.12.30 19-43-24.png

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20151223030323
STR:
1. Set DPI -> 125% :
 A) Set that DPI level -> 125% in your OS   [OR]
 B) Set layout.css.devPixelsPerPx -> 1.25
2. Click (≡) -> "Customize", place Pocket button on toolbar

Result:       Pocket button of toolbar button looks broken
Expectations: Should look normal, just like on normal DPI

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1235845 - add the pocket stylesheet to browser windows instead of using the stylesheet service, r?mixedpuppy

Review commit: https://reviewboard.mozilla.org/r/29275/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29275/

Comment 2

[:Gijs (he/him)]

Using the stylesheet service means ordering isn't guaranteed, plus the sheets get used for every single webpage we render. Both of those seem like bad ideas, so let's not do that. Not sure why I didn't flag this up originally, sorry. :-(

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ff863d8cdf7a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff863d8cdf7a

Comment 5

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
STR: 
DPI to 125 if on win 7, properties -> screen resolution -> Medium 125% -> log off and log in to continue

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Icon is not broken despite of DPI is 125.

Actual Results: 
As expected