1235864 - about:profiles, "Start Nightly" button doesn't do anything after I delete "default" profile

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20151230030234
STR:
1. Open Brand NEW profile manager, create new profile
   Make sure checkbox "Use the selected profile without asking at startup" is checked
   Make sure profile from Step 1 is selected
2. Click button "Set as default profile" next to the profile from Step 1
3. Click button "Remove" next to the profile from Step 1, click "Delete files"
4. Click button "Set as default profile" next to any other profile
5. Click button "Start Nightly" at the bottom of the page

Result:       Nothing
Expectations: It should start Nightly with selected profile

// Also, if you're aware, please tell me why it was decided to implement regressive bug 1232629

Comment 1

[Andrea Marchesini [:baku]]

Attachment: profileG.patch

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9190c3a5af82

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9190c3a5af82

Comment 4

[arni2033]

The case described in comment 0 is fixed on Win7_64, Nightly 46, 32bit, ID 20160105030211

I'm not marking it as "Verified" yet, because I think it still may cause issues (see comment 5)

Comment 5

[arni2033]

The added block of code does nothing when user deletes the last profile. Could somebody test the following scenario? (I have ~16 profiles currently)

1. Open Brand NEW profile manager, delete all profiles
2. Click button "Create a New Profile",  click "Next",  click "Finish"   [profile is created]
3. Click button "Set as default profile" next to the only profile (just in case)
4. Click button "Start Nightly" at the bottom of the page

Expectations:
 Nightly should launch the profile created in Step 2