Closed Bug 1235873 Opened 4 years ago Closed 4 years ago

panel size incorrect when pocket is in australis menu

Categories

(Firefox :: Pocket, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

Attachments

(2 files)

Looks like the panel is being sized as if it were the panel under the pocket button when in the toolbar.
Blocks: 1215694
I believe this may be a change in nightly.  In 45, the panel sizes correctly, in 46 (nightly) the panel sizes to 100px.  In *BOTH* the pocket code is setting the iframe size to subview.clientHeight + "px", which is 100px.  I cannot find any difference in styles (when the pocket button is located in the menu panel) between built-in pocket in 45 and addon in 46.
screenshot of the problem.
Blocks: 1236014
No longer blocks: 1236014
Assignee: nobody → mixedpuppy
Attachment #8710718 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8710718 [details] [diff] [review]
fix pocket panel size when in menu panel

Review of attachment 8710718 [details] [diff] [review]:
-----------------------------------------------------------------

r=me because it works, and this isn't code you originally wrote, but ugh. :-)

::: browser/extensions/pocket/content/main.js
@@ -303,4 @@
>       */
>      function resizePanel(options) {
>          var iframe = getPanelFrame();
>          var subview = getSubview();

FWIW, isn't that panelview always #PanelUI-pocketView ? Can just use getElementById in getSubview(), right, and check the attribute on there? rs=me to just fix that while we're here...
Attachment #8710718 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c1d1dfc7a40d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.