1235873 - panel size incorrect when pocket is in australis menu

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Looks like the panel is being sized as if it were the panel under the pocket button when in the toolbar.

Comment 1

[Shane Caraveo (:mixedpuppy)]

I believe this may be a change in nightly.  In 45, the panel sizes correctly, in 46 (nightly) the panel sizes to 100px.  In *BOTH* the pocket code is setting the iframe size to subview.clientHeight + "px", which is 100px.  I cannot find any difference in styles (when the pocket button is located in the menu panel) between built-in pocket in 45 and addon in 46.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Screen Shot 2015-12-30 at 1.01.53 PM.png

screenshot of the problem.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: fix pocket panel size when in menu panel

Comment 4

[:Gijs (he/him)]

Comment on attachment 8710718 [details] [diff] [review]
fix pocket panel size when in menu panel

Review of attachment 8710718 [details] [diff] [review]:
-----------------------------------------------------------------

r=me because it works, and this isn't code you originally wrote, but ugh. :-)

::: browser/extensions/pocket/content/main.js
@@ -303,4 @@
>       */
>      function resizePanel(options) {
>          var iframe = getPanelFrame();
>          var subview = getSubview();

FWIW, isn't that panelview always #PanelUI-pocketView ? Can just use getElementById in getSubview(), right, and check the attribute on there? rs=me to just fix that while we're here...

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c1d1dfc7a40d

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c1d1dfc7a40d

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected