Closed Bug 1235970 Opened 4 years ago Closed 4 years ago

Intermittent ASan test_bug582181-2.html | entering '>' should restore original rendering: expected data:image/png;base64

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: philor, Assigned: jfkthame)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Pretty sure these have been failing all along since the GTK+3 switch for ASan, but we've been ignoring them in the midst of the failure messages for bug 1204897 and bug 1221919.

https://treeherder.mozilla.org/logviewer.html#?job_id=2977026&repo=mozilla-central
This looks a lot like bug 1221919, so I suggest we apply the same workaround as you used there.
Attachment #8706297 - Flags: review?(dholbert)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Indeed, the "Expected...but got" screenshots show diagonal-lines vs. dots on the resize grabber.
Comment on attachment 8706297 [details] [diff] [review]
Disable resizing of textarea to work around unreliable Gtk3 rendering of the resize grabber

Review of attachment 8706297 [details] [diff] [review]:
-----------------------------------------------------------------

> Bug 1235970 - Disable resizing of textarea to work around unreliable Gtk3 rendering of the resize grabber. r?dholbert
As in bug 1237355, please mention the name of the testcase (or just "in a mochitest") in the commit message.

Otherwise, this gives the impression that you're actually changing how <textarea> works in general.

r=me with that
Attachment #8706297 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/21fcc39026407623cf9cf195d493e1af0b5b3097
Bug 1235970 - Disable resizing of textarea in mochitest test_bug582181-2 to work around unreliable Gtk3 rendering of the resize grabber. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/21fcc3902640
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.