Closed Bug 1237355 Opened 9 years ago Closed 9 years ago

Intermittent ASan test_bug499538-1.html | Arabic text between English words not connected

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: aryx, Assigned: jfkthame)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Use -moz-appearance:none to work around unreliable Gtk3 theming of input widget
1.22 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
patch 2 - Use -moz-appearance:none to work around unreliable Gtk3 theming of textarea
1.19 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
https://treeherder.mozilla.org/logviewer.html#?job_id=19374075&repo=mozilla-inbound Seems to be the most often on Linux x64 asan. Already occured on 20160101: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8d40c30f5b Wes assumes it was hiding behind bug 1234659. 09:10:41 INFO - 313 INFO TEST-START | layout/base/tests/test_bug499538-1.html 09:10:42 INFO - TEST-INFO | started process screentopng 09:10:44 INFO - TEST-INFO | screentopng: exit 0 09:10:44 INFO - 314 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug499538-1.html | Arabic text between English words not connected: expected data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAfQAAAEsCAYAAAA1u0HIAAAHmklEQVR4nO3dUVLbZgBGURbo/S+jbzGJE0KfaAmx7F+WsMXVOTPftFWEJWCGi9WZ9ukVAPjynh59AwDAcoIOAAGCDgABgg4AAYIOAAGCDgABgg4AAYIOAAGCDgABXy7oT0//PPoWAGBzhoL+9PTPf1vz3Ft8fN1z11r7+u8/p4/bokv3Nnr/I+eNfk3mfN2+wtcXYIuG36HPDfo9TUXkHtfYWnSuhfWzj03dz7Xjo+cBcN6soL//663nfIZHBf0zrrPU1Pdg5Ps257xr537mdQH4212Dfsuj2ffnLn3nOXIP1z630WvPfbc55/MducetBP0SQQdYz+ygf/z7W/586tha58x5rdFY3BLoOa8z57WnXvcRQV/rFySP3AGWuUvQb333de6H+Zr/fnfueXMCNhr0td6ZXnvde71DH/l+jp4j5ADjbgr6x39eKyYjf/bIoH/G8TWCvvTrNBrqNb+ma38fAfZus0Ff45H1uWO3PiZe4xePc8eXBv3So+pL57//uJGv1ej93HreWk8qAPbq5qC/HRuJyVoxnHP+6D1Ugn5pI68xQtABtmtzQb/2CFjQx9z6+a9932ufB8B5i4I+59y1ji0J+sixKdceYY8cn/N4fM69Td3XLfez5Njodc+dN+cYAH+763/69dqj4GuPjc997OixqeuPfF63Ps6ec72pc+e6dI+j937redd+6Vnz2gD86cv9z1n2RNAAGHU16JfenZrdcwBM8w59I8QLgCUEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAKGg346nV6Px+Prt2/fzGyjOx6Pr6fT6TN/ZgAbNRT00+n08B9UZjY+UYf9GQr68/Pz6/F4NLMvsufn58/+2QFszFDQH/3DyczmD9gXQTeLDtiX4UfuW9vhcHj4PZhtecC+CLpZdMC+DAX9+/fvm9vhcHj4PZhtecC+CLpZdMC+DAX9x48fkzscDn/s0rlv54+cc+28j9cdeV2zPQ3Yl8VB/7glYV36i4Gom/0/YF/uGvRrwZ4T5DVew6w8YF+G/9OvUzv36PvW86Y+dur15hw329uAfVkU9DlRfh/x0aBfirOgm10esC9DQf/58+fZHQ6HoWPv/+xt1/780nmXrnPpY8z2NGBf7hb094GeivVIyG+5ttkeB+zLUNB//fo1uXPvqqfOu/ZxUx+75Lpmex2wL4uDPjrBNbvvgH0ZCvrLy8vivb2LXuO1zOz6gH25W9BfXl4mH7MLvdn6A/blrkE3s/sN2JehoP/+/dvMvtiAfRkK+uurqJt9pQH7Mxx0AGC7BB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAgQdAAIEHQACBB0AAv4FkFTlq7NwOLkAAAAASUVORK5CYII= but got data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAfQAAAEsCAYAAAA1u0HIAAAHpklEQVR4nO3d7U7bZgCGYQ7Q538Y/VdoS1P2o+pEaRK/dkw+bl+X9GibcRIDEjdxp+3pDQB4eE+3vgAA4HKCDgABgg4AAYIOAAGCDgABgg4AAYIOAAGCDgABgg4AAQ8X9KenL7e+BAC4O0NBf3r68v+2PHeNj8977LW2fv33n9PH3aNz1zZ6/SPnjX5NlnzdHuHrC3CPht+hLw36NZ2KyDVe496iMxfWzz526nrmjo+eB8Bxi4L+/q9rz/kMtwr6Z7zOpU59D0a+b0vOmzv3M18XgH9dNehrbs2+P/fSd54j1zD3uY2+9tJ3m0s+35FrvJegnyPoANtZHPSPf7/m46eObXXOkucajcWaQC95niXPfep5bxH0rX5Bcssd4DJXCfrad1/Hfphv+ee7S89bErDRoG/1znTuea/1Dn3k+zl6jpADjFsV9I//vFVMRj52y6B/xvEtgn7p12k01Ft+Tbf+PgLs3d0GfYtb1seOrb1NvMUvHseOXxr0c7eqz53//nEjX6vR61l73lZ3KgD2anXQ/xwbiclWMVxy/ug1VIJ+biPPMULQAe7X3QV97hawoI9Z+/lvfd1bnwfAcRcFfcm5Wx27JOgjx06Zu4U9cnzJ7fEl13bqutZczyXHRl/32HlLjgHwr6v+p1/nbgXP3TY+9tjRY6def+TzWns7e8nrnTp3qXPXOHrta8+b+6Vny9cG4G8P9z9n2RNBA2DUbNDPvTs1u+YAOM079DshXgBcQtABIEDQASBA0AEgQNABIEDQASBA0AEgQNABIEDQASBA0AEgQNABIEDQASBA0AEgQNABIEDQASBA0AEgQNABIEDQASBgKOgvz89vX79+NbMH2cvL82f/7ADuzGzQX17E3OwRJ+qwL7NBv/UPJTNbP2A/ZoP+/PxsZg86YD8E3Sw8YD8G/gz9xcwedMB+PGzQp2m6+TWY3fuA/RB0s/CA/ZgN+rdv3+5y0zTd/BrM7n3Afgi6WXjAfswG/fv372c3TdNfGzl/9DmXvO7I85rtbcB+XBz0j7skrJf+YiDqZn8P2I+rBn0u2EuCvMVzmNUH7Mds0H/8+HF2x259rz3v1GNPPd+S42Z7HLAfFwV9SZTfR3w06OfiLOhm8wP2Yzbor6+vJzdN09Cx9x/7s7mPnzvv3Ouce4zZ3gbsx9WC/j7Qp2I9EvI1r2221wH7cVHQX1/H31V/PH7scUuCfMljzfYyYD9mg/7z589NNk3TZs9lZmMD9uOqQRd1s+sO2I/ZoB8Oh8126jb7NE2bvo6Z/R6wH1cNupldd8B+DN1yv/UPJTNbPrfcYV8G/i33H2+/fv0yswfb66v/sAzsyWzQ395+R/1wONz8B5SZze9wOIg57NBQ0AGA+yboABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAECDoABAg6AAQIOgAEPAfNwy98aUHAyMAAAAASUVORK5CYII= 09:10:44 INFO - test@layout/base/tests/test_bug499538-1.html:51:3 09:10:44 INFO - onload@layout/base/tests/test_bug499538-1.html:1:1 09:10:44 INFO - MEMORY STAT | vsize 20972447MB | residentFast 341MB 09:10:44 INFO - 315 INFO TEST-OK | layout/base/tests/test_bug499538-1.html | took 888ms
Summary: Intermittent test_bug499538-1.html | Arabic text between English words not connected → Intermittent e10s test_bug499538-1.html | Arabic text between English words not connected
(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #0) > layout/base/tests/test_bug499538-1.html | Arabic text between English words > not connected: expected >... Looking at the "expected" vs "got" images, the failure is not actually related to rendering of the RTL/Arabic text, which is fine in both. The discrepancy seems to relate to the size of the slightly-shaded background of the <input> element, which I guess is related to Gtk theming. I believe we've seen some other intermittents where it seems like inconsistent rendering of Gtk-themed widgets is an issue. Maybe adding -moz-appearance:none to the <input> element would be a workaround?
Depends on: 1223198
Summary: Intermittent e10s test_bug499538-1.html | Arabic text between English words not connected → Intermittent ASan test_bug499538-1.html | Arabic text between English words not connected
This often seems to be accompanied by a similar failure in test_bug644768.html: 253 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug644768.html | newline before bidi text shouldn't change direction: expected data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAfQAAAEsCAYAAAA1u0HIAAAIXUlEQVR4nO3dS24cVRiGYS8H2ANiA5mGHWQnSLAKxE5C7sAkIRmAWEF8h8iXXAbFgASQ3e3zn+py++TL80mPgHa5u2ykvK6yDTuTmZmZffTbuekTMDMzs80n6GZmZgETdDMzs4AJupmZWcAE3czMLGCCbmZmFjBBNzMzC5igm5mZBUzQzczMAvbRBX1n5+imT8HMzGy4lYK+s3P0ryWPnbOLz7vqtZZ+/f9/TBeNtN5z2+S4qz4n655zqWPMzOzyylfoS0diya16vaXPYd1 Guessing the same workaround can be applied to both. I'll ask tryserver's opinion...
Similar to bug 1204897, if we turn off the theming we should avoid the Gtk3/asan unreliability.
Attachment #8706299 - Flags: review?(dholbert)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
And the same applies here, too; the failures often seem to show up together.
Attachment #8706308 - Flags: review?(dholbert)
Try run with both these patches, plus bug 1235970: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa6403aa22d9 (A run that had only the first of the two patches here, highlighting the failure in test_bug644768 as in comment 4: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c95a19f2ee14.)
Comment on attachment 8706299 [details] [diff] [review] Use -moz-appearance:none to work around unreliable Gtk3 theming of input widget Review of attachment 8706299 [details] [diff] [review]: ----------------------------------------------------------------- You probably want to add "patch 1" to commit message (to match "patch 2" in the other patch). r=me with something like that
Attachment #8706299 - Flags: review?(dholbert) → review+
Also: probably worth mentioning the name of the testcase in the commit message, or just adding "in a mochitest". Otherwise the commit message sounds like this might be a platform-level workaround for GTK inconsistencies in general.
Comment on attachment 8706308 [details] [diff] [review] patch 2 - Use -moz-appearance:none to work around unreliable Gtk3 theming of textarea Review of attachment 8706308 [details] [diff] [review]: ----------------------------------------------------------------- >Bug 1237355 - patch 2 - Use -moz-appearance:none to work around unreliable Gtk3 theming of textarea. r?dholbert As noted in comment 9, please mention the testcase name (or "in a mochitest") in this patch's commit message, as well. r=me
Attachment #8706308 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc782b12d96e8bcf0033a7db61fa17980fc76ce Bug 1237355 - patch 1 - Use -moz-appearance:none on input widget in mochitest test_bug499538-1 to work around unreliable Gtk3 theming. r=dholbert https://hg.mozilla.org/integration/mozilla-inbound/rev/24b816ff619da1a1f9e34830e467e6d72cfc3d8c Bug 1237355 - patch 2 - Use -moz-appearance:none on textarea in mochitest test_bug644768 to work around unreliable Gtk3 theming. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/7fc782b12d96 https://hg.mozilla.org/mozilla-central/rev/24b816ff619d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
status-firefox45: --- → affected
Whiteboard: [checkin-needed-aurora]
has problem during uplift, could you take a look, thanks!
Flags: needinfo?(jfkthame)
Flags: needinfo?(jfkthame)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: