1236042 - Create hotfix addon to update media.youtube-ua.override to false in Firefox 43.0.3

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

When Youtube will have fixed their bug, we will disable the workaround.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: youtube-workaround-hotfix.diff

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Comment on attachment 8703149 [details] [diff] [review]
youtube-workaround-hotfix.diff

Review of attachment 8703149 [details] [diff] [review]:
-----------------------------------------------------------------

Looks okay. There's just a discrepancy in which versions this applies to. As it stands, it will only apply to 43.0.3 - 43.*. If that's what we want, r+

::: v20151231.01/install.rdf
@@ +21,1 @@
>          <em:maxVersion>43.*</em:maxVersion>

Shouldn't the maxVersion be 44.* to match what's in bootstrap.js?

Comment 3

[Chris Peterson [:cpeterson]]

YouTube says they plan to re-enable VP9 next week. They don't know exactly when.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: foo.dif

Actually, I only want the version 43.0.3 to be updated. 
Is this declaration correct?
  if (Services.vc.compare(Services.appinfo.version, "43.0.3") == 0) {

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Comment on attachment 8703291 [details] [diff] [review]
foo.dif

Review of attachment 8703291 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. 43.0.3 isn't in the allowed AMO versions, but I added it for this.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/firefox-hotfixes/rev/3d48779b0399
Actually, we need to update also 43.0.3 & 43.0.4.