Closed Bug 1237209 Opened 9 years ago Closed 9 years ago

Please sign the plugin update media.youtube-ua.override hotfix xpi (v20151231.01)

Categories

(addons.mozilla.org Graveyard :: Administration, defect)

Product:
addons.mozilla.org Graveyard
Component:
Administration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Sylvestre, Unassigned)

References

Details

Attachments

(1 file)

Signed hotfix
5.47 KB, application/x-xpinstall
Details
To generate the XPI, do the following: hg clone https://hg.mozilla.org/releases/firefox-hotfixes cd firefox-hotfixes HOTFIX=v20151231.01 update make package Then we need to sign the xpi generated at build/hotfix-v20151231.01.xpi Please DO NOT push until confirmation (we need a confirmation from youtube). We won't need to rename the pref as it is going to be removed.
Having a second look on the affected versions would be appreciated.
status-firefox43: --- → affected
Flags: needinfo?(kmaglione+bmo)
Attached file Signed hotfix —
Signed hotfix is attached.
Flags: needinfo?(kmaglione+bmo)
Jorge, could you upload the addon on the staging server? Thanks
Flags: needinfo?(jorge)
The hotfix is now staged. Note that in bug 1234807 we had some problems testing the staged file, and I don't think those problems have been resolved.
Flags: needinfo?(jorge)
YouTube says they have deployed the FF 43 fix on their side, but it doesn't seem to be working for me. I still receive 360p VP8 instead of VP9 (when MP4 is not available).
I have Firefox 43.04 on Mac OS X and I get the header override. Note that to youtube.com it says 42 and to firefox.com it says 43. Host: www.youtube.com User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:42.0) Gecko/20100101 Firefox/42.0 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en-US,en;q=0.5 Accept-Encoding: gzip, deflate Cookie: PREF=f5=30030; VISITOR_INFO1_LIVE=guanJulH2pU; dkv=c8cf6aea8747c77a29d02b69bc3f980ee3QEAAAAdGxpcGk6Yo5WMA==; YSC=WnzAUxxySHo Connection: keep-alive Cache-Control: max-age=0 Host: www.firefox.com User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:43.0) Gecko/20100101 Firefox/43.0 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en-US,en;q=0.5 Accept-Encoding: gzip, deflate Connection: keep-alive
Richard, we haven't deployed the hotfix yet. We are waiting for a confirmation Youtube behaves in correct way (what Chris said in comment #5).
Flags: needinfo?(rleider)
Chris can you show the headers you have in the environment that is not working as expected? Also, could you right click on the player, select Copy Debug Info and then send the result?
Flags: needinfo?(rleider)
Sylvestre, YouTube now works correctly for me on Windows XP when I disable the 43's UA override. We should push out this hotfix when you're ready.
Flags: needinfo?(sledru)
Indeed! Florin, could you find someone to help us with this hot fix verification? We should: * check with 43.0.2, 43.0.3 and 43.0.4 * check that the media.youtube-ua.override property exists in 43.0.3 and 43.0.4 and NOT in 43.0.2 * that this property is true in 43.0.3 and 43.0.4 * the hotfix turns it to false Thanks!
Flags: needinfo?(sledru) → needinfo?(florin.mezei)
We should also come back in this bug when 44 is released to make sure we are not trying to apply this hotfix.
Andrei, can you help? Thanks
Flags: needinfo?(andrei.vaida)
(In reply to Sylvestre Ledru [:sylvestre] from comment #12) > Andrei, can you help? Thanks Bogdan will follow up here with test results as soon as possible.
Flags: needinfo?(florin.mezei)
QA Contact: bogdan.maris
(In reply to Sylvestre Ledru [:sylvestre] from comment #10) > Indeed! > Florin, could you find someone to help us with this hot fix verification? > > We should: > * check with 43.0.2, 43.0.3 and 43.0.4 > * check that the media.youtube-ua.override property exists in 43.0.3 and > 43.0.4 and NOT in 43.0.2 > * that this property is true in 43.0.3 and 43.0.4 > * the hotfix turns it to false > > Thanks! All the points from above were verified. I tested across platforms (Windows 10 64bit, Windows XP 32/64bit, Ubuntu 14.04 64bit and Mac OS X 10.11). If there is something extra that need to be tested please let me know. See bellow for detailed results. Windows XP 32-bit. = 43.0.2 == media.youtube-ua.override NOT Unable to install Hotfix due to incompatibility with this FF version. "Disable the youtube override introduced in 43.0.3 could not be installed because it is not compatible with Firefox 43.0.2" notification HTML5 enabled by default = 43.0.3 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 Flash enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default after restart = 43.0.4 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 Flash enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default after restart Windows XP 64-bit. = 43.0.2 == media.youtube-ua.override NOT Unable to install Hotfix due to incompatibility with this FF version. "Disable the youtube override introduced in 43.0.3 could not be installed because it is not compatible with Firefox 43.0.2" notification HTML5 enabled by default = 43.0.3 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 Flash enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default after restart = 43.0.4 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 Flash enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default after restart Windows 10 64 Dell = 43.0.2 == media.youtube-ua.override NOT Unable to install Hotfix due to incompatibility with this FF version. "Disable the youtube override introduced in 43.0.3 could not be installed because it is not compatible with Firefox 43.0.2" notification HTML5 enabled by default = 43.0.2 64bit == Same as above = 43.0.3 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default = 43.0.3 64bit == Same as above = 43.0.4 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default = 43.0.4 64bit == Same as above Mac OS X 10.11 = 43.0.2 == media.youtube-ua.override NOT Unable to install Hotfix due to incompatibility with this FF version. "Disable the youtube override introduced in 43.0.3 could not be installed because it is not compatible with Firefox 43.0.2" notification HTML5 enabled by default = 43.0.3 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default = 43.0.4 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default Ubuntu 14.04 64-bit = 43.0.2 == media.youtube-ua.override NOT Unable to install Hotfix due to incompatibility with this FF version. "Disable the youtube override introduced in 43.0.3 could not be installed because it is not compatible with Firefox 43.0.2" notification HTML5 enabled by default = 43.0.3 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 Flash enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default after restart = 43.0.4 == default: media.youtube-ua.override true media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 Flash enabled by default == hotfix: media.youtube-ua.override false media.youtube-ua.override.from 43 media.youtube-ua.override.to 42 HTML5 enabled by default after restart
Flags: needinfo?(andrei.vaida)
You rock, this is just great! Thanks! Jorge, we are ready to go live with this hotfix. Thanks!
Flags: needinfo?(jorge)
This hotfix is now live.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jorge)
Resolution: --- → FIXED
How can a user tell whether they have the hotfix installed? In my two FF 43.0.4 test profiles (OS X and XP), I still see the "media.youtube-ua.override" = true, suggesting I haven't received the hotfix.
The documentation can be found here: https://wiki.mozilla.org/Add-ons/Hotfix The hotfix is generally coded to remove itself, so you won't have it installed on your profile for long. The best way to know which was the last hotfix you had installed is to check the preference extensions.hotfix.lastVersion
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: