Closed Bug 1236071 Opened 4 years ago Closed 4 years ago

Remove android:panelBackground if open web apps are removed

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mcomella, Assigned: bdahl)

References

Details

Attachments

(2 files)

The attribute is needed in open web apps (see bug 1234544). If open web apps are removed (bug 1235869), we should remove the attribute and assets again.

Note the previous attempt to do this in bug 1229958 (before I knew it was needed in open web apps).
Assignee: nobody → bdahl
Comment on attachment 8726445 [details] [diff] [review]
0001-Bug-1236071-Remove-unused-android-panelBackground.patch

Review of attachment 8726445 [details] [diff] [review]:
-----------------------------------------------------------------

You can also remove the menu_panel_bg asset. It appears to be unused:
  https://mxr.mozilla.org/mozilla-central/search?string=menu_panel_bg&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

You can find it here and can remove the asset from all configurations:
  https://mxr.mozilla.org/mozilla-central/find?text=&string=menu_panel_bg
Attachment #8726445 - Flags: review?(michael.l.comella) → review+
Removed the assets. Carrying r+ forward.
Attachment #8727673 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b24861dc477a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.