1236071 - Remove android:panelBackground if open web apps are removed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The attribute is needed in open web apps (see bug 1234544). If open web apps are removed (bug 1235869), we should remove the attribute and assets again.

Note the previous attempt to do this in bug 1229958 (before I knew it was needed in open web apps).

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: 0001-Bug-1236071-Remove-unused-android-panelBackground.patch

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8726445 [details] [diff] [review]
0001-Bug-1236071-Remove-unused-android-panelBackground.patch

Review of attachment 8726445 [details] [diff] [review]:
-----------------------------------------------------------------

You can also remove the menu_panel_bg asset. It appears to be unused:
  https://mxr.mozilla.org/mozilla-central/search?string=menu_panel_bg&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

You can find it here and can remove the asset from all configurations:
  https://mxr.mozilla.org/mozilla-central/find?text=&string=menu_panel_bg

Comment 3

[Brendan Dahl [:bdahl]]

Attachment: 0001-Bug-1236071-Remove-unused-android-panelBackground.patch

Removed the assets. Carrying r+ forward.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b24861dc477a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b24861dc477a