Closed Bug 1229958 Opened 4 years ago Closed 4 years ago

Remove android:panelBackground

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1229958 - Remove android:panelBackground. r=sebastian
40 bytes, text/x-review-board-request
sebastian
: review+
Details 
I'm not entirely clear on what it does, but I think it's supposed to set the background color of menus.

However, considering the menu on GB works just fine with a strange panelBackground color set, I don't think it's necessary given our custom menu.
Bug 1229958 - Remove android:panelBackground. r=sebastian

There is no noticeable difference in background color of the menu on my 4.* GS4
or my 2.3 Nexus S, though perhaps it affects more than the menu.

The menu_panel_bg drawable is now unused so I removed that too.
Attachment #8694996 - Flags: review?(s.kaspari)
Attachment #8694996 - Flags: review?(s.kaspari) → review+
Comment on attachment 8694996 [details]
MozReview Request: Bug 1229958 - Remove android:panelBackground. r=sebastian

https://reviewboard.mozilla.org/r/26949/#review24421
https://hg.mozilla.org/mozilla-central/rev/535bb5015ea1
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
NI self (once the tree reopens) to:
 1) backout this bug
 2) close bug 1230648
 3) Mark this depending on bug 1209967
 4) explain why I did this
Flags: needinfo?(michael.l.comella)
We can probably do this again once we land bug 1209967.

I had to back this out because bug 1230648 requires android:panelBackground on devices with hardware menu buttons.
Status: RESOLVED → REOPENED
Depends on: 1209967
Flags: needinfo?(michael.l.comella)
Resolution: FIXED → ---
Tested this on my GS4 and I don't have any issues after bug 1209967 so I'm going to reland this.
https://hg.mozilla.org/mozilla-central/rev/1fd198f1bdbf
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: Firefox 45 → Firefox 46
Note that we'll be undoing most of this in bug 1234544 due to open web apps, but not all of it, which is why I'm not backing this out.
Looks like I screwed up the flags here:
 h log -fr aurora | grep "Bug 1229958"
 summary:     Bug 1229958 - Backout 535bb5015ea1 for regression bug 1230648. r=me
 summary:     Bug 1229958 - Remove android:panelBackground. r=sebastian
status-firefox45: fixed → ---
You need to log in before you can comment on or make changes to this bug.