Closed
Bug 1229958
Opened 7 years ago
Closed 7 years ago
Remove android:panelBackground
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
I'm not entirely clear on what it does, but I think it's supposed to set the background color of menus. However, considering the menu on GB works just fine with a strange panelBackground color set, I don't think it's necessary given our custom menu.
Assignee | ||
Comment 1•7 years ago
|
||
Bug 1229958 - Remove android:panelBackground. r=sebastian There is no noticeable difference in background color of the menu on my 4.* GS4 or my 2.3 Nexus S, though perhaps it affects more than the menu. The menu_panel_bg drawable is now unused so I removed that too.
Attachment #8694996 -
Flags: review?(s.kaspari)
Updated•7 years ago
|
Attachment #8694996 -
Flags: review?(s.kaspari) → review+
Comment 2•7 years ago
|
||
Comment on attachment 8694996 [details] MozReview Request: Bug 1229958 - Remove android:panelBackground. r=sebastian https://reviewboard.mozilla.org/r/26949/#review24421
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/535bb5015ea1b1ced4aa1fb39b88eace3b324264 Bug 1229958 - Remove android:panelBackground. r=sebastian
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/535bb5015ea1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Assignee | ||
Comment 5•7 years ago
|
||
NI self (once the tree reopens) to: 1) backout this bug 2) close bug 1230648 3) Mark this depending on bug 1209967 4) explain why I did this
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1fbccc6fa1c022f82a60c951711bd9281626ea4f Bug 1229958 - Backout 535bb5015ea1 for regression bug 1230648. r=me
Assignee | ||
Comment 7•7 years ago
|
||
We can probably do this again once we land bug 1209967. I had to back this out because bug 1230648 requires android:panelBackground on devices with hardware menu buttons.
Status: RESOLVED → REOPENED
Depends on: 1209967
Flags: needinfo?(michael.l.comella)
Resolution: FIXED → ---
Assignee | ||
Comment 8•7 years ago
|
||
Tested this on my GS4 and I don't have any issues after bug 1209967 so I'm going to reland this.
Assignee | ||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1fd198f1bdbf3c8cde06b6b1d0c8a67d2e3fcad3 Bug 1229958 - Remove android:panelBackground. r=sebastian
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1fd198f1bdbf
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: Firefox 45 → Firefox 46
Assignee | ||
Comment 11•7 years ago
|
||
Note that we'll be undoing most of this in bug 1234544 due to open web apps, but not all of it, which is why I'm not backing this out.
Assignee | ||
Comment 12•7 years ago
|
||
Looks like I screwed up the flags here: h log -fr aurora | grep "Bug 1229958" summary: Bug 1229958 - Backout 535bb5015ea1 for regression bug 1230648. r=me summary: Bug 1229958 - Remove android:panelBackground. r=sebastian
status-firefox45:
fixed → ---
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•