1229958 - Remove android:panelBackground

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'm not entirely clear on what it does, but I think it's supposed to set the background color of menus.

However, considering the menu on GB works just fine with a strange panelBackground color set, I don't think it's necessary given our custom menu.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1229958 - Remove android:panelBackground. r=sebastian

Bug 1229958 - Remove android:panelBackground. r=sebastian

There is no noticeable difference in background color of the menu on my 4.* GS4
or my 2.3 Nexus S, though perhaps it affects more than the menu.

The menu_panel_bg drawable is now unused so I removed that too.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8694996 [details]
MozReview Request: Bug 1229958 - Remove android:panelBackground. r=sebastian

https://reviewboard.mozilla.org/r/26949/#review24421

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/535bb5015ea1b1ced4aa1fb39b88eace3b324264
Bug 1229958 - Remove android:panelBackground. r=sebastian

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/535bb5015ea1

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI self (once the tree reopens) to:
 1) backout this bug
 2) close bug 1230648
 3) Mark this depending on bug 1209967
 4) explain why I did this

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/1fbccc6fa1c022f82a60c951711bd9281626ea4f
Bug 1229958 - Backout 535bb5015ea1 for regression bug 1230648. r=me

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We can probably do this again once we land bug 1209967.

I had to back this out because bug 1230648 requires android:panelBackground on devices with hardware menu buttons.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Tested this on my GS4 and I don't have any issues after bug 1209967 so I'm going to reland this.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/1fd198f1bdbf3c8cde06b6b1d0c8a67d2e3fcad3
Bug 1229958 - Remove android:panelBackground. r=sebastian

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1fd198f1bdbf

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note that we'll be undoing most of this in bug 1234544 due to open web apps, but not all of it, which is why I'm not backing this out.

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Looks like I screwed up the flags here:
 h log -fr aurora | grep "Bug 1229958"
 summary:     Bug 1229958 - Backout 535bb5015ea1 for regression bug 1230648. r=me
 summary:     Bug 1229958 - Remove android:panelBackground. r=sebastian