1236213 - Private browsing icon on toolbar displays a small black line at the left side when dark lightweight theme is in use

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[arni2033]

Attachment: screenshot 1 - a small black line at the left side of the icon.png

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160101030330
STR:
1. Install and enable theme https://addons.mozilla.org/ru/firefox/addon/outlook-2013-blue/
2. Place Private Mode button on the navigation toolbar
3. Hover mouse over the button

Result:       There's a small black line at the left side of the icon
Expectations: There should be no extra black lines

Comment 1

[:Gijs (he/him)]

Stephen, any chance you could look at getting us a new sprite for this and bug 1236214 ?

Comment 2

[arni2033]

Attachment: screenshot 2 (comment 2) - new tab icon is clipped by 1px.png

Hm, I just checked ALL icons and found that "New tab" icon, on the other side, is clipped by 1px

I first thought that this can be fixed by just moving Private Browsing icon 1px to the right, but now I see that it won't fix "New tab" icon anyway. Please tell if this requires another bug report

Comment 3

[:Gijs (he/him)]

(In reply to arni2033 from comment #2)
> Created attachment 8703570 [details]
> screenshot 2 (comment 2) - new tab icon is clipped by 1px.png
> 
> Hm, I just checked ALL icons and found that "New tab" icon, on the other
> side, is clipped by 1px
> 
> I first thought that this can be fixed by just moving Private Browsing icon
> 1px to the right, but now I see that it won't fix "New tab" icon anyway.
> Please tell if this requires another bug report

Nah, we should just fix the sprite in one go.

Comment 4

[arni2033]

>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161001030430 (2016-10-01)
Reproducible on normal DPI and HiDPI (125%)

(In reply to :Gijs Kruitbosch from comment #3)
> Nah, we should just fix the sprite in one go.
One more bug with the same sprite (almost not noticeable):
1 black pixel from the left side of Share this page icon appears at the right of RSS icon

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Mass wontfix for bugs affecting firefox 52.