1236569 - TEST-UNEXPECTED-ERROR | test_direct_update.py TestDirectUpdate.test_update | AttributeError: 'AboutWindow' object has no attribute 'download'

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This failure is not always happening and is only visible for tests around Christmas. Not sure in which state the update channels were during those days but it should be worth checking the test why this is occurring.

 06:45:01     INFO - TEST-UNEXPECTED-ERROR | test_direct_update.py TestDirectUpdate.test_update | AttributeError: 'AboutWindow' object has no attribute 'download'
 06:45:01     INFO - 
 06:45:01     INFO - Traceback (most recent call last):
 06:45:01     INFO -   File "c:\jenkins\workspace\mozilla-aurora_update\build\venv\lib\site-packages\marionette\marionette_test.py", line 344, in run
 06:45:01     INFO -     testMethod()
 06:45:01     INFO -   File "c:\jenkins\workspace\mozilla-aurora_update\build\venv\lib\site-packages\firefox_ui_tests\update\direct\test_direct_update.py", line 26, in test_update
 06:45:01     INFO -     self._test_update()
 06:45:01     INFO -   File "c:\jenkins\workspace\mozilla-aurora_update\build\venv\lib\site-packages\firefox_ui_tests\update\direct\test_direct_update.py", line 22, in _test_update
 06:45:01     INFO -     self.check_update_applied()
 06:45:01     INFO -   File "c:\jenkins\workspace\mozilla-aurora_update\build\venv\lib\site-packages\firefox_puppeteer\testcases\update.py", line 157, in check_update_applied
 06:45:01     INFO -     about_window.download(wait_for_finish=False)

So far it was only visible for Aurora builds but not Nightly.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Problem is located here and a regression from my fix on bug 1232331:

https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_puppeteer/testcases/update.py#L156

It only happens if a second update is still available after the first one has been done. 

All branches except esr38 are affected. For mozilla-central we also need a patch for hg.mo.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Will fix that once bug 1232967 has been fixed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets also get this fixed before we merge the python_packages branch into mozilla-central. Getting the change onto that branch is easier than expected.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Github PR

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Merged PR to the mozilla-central branch:

https://github.com/mozilla/firefox-ui-tests/commit/291b7088fbc4b2e5a8f2e1f72cd042f52b528513

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Cherry-picked for other affected branches:

https://github.com/mozilla/firefox-ui-tests/commit/f7c3a911111bc783c8eae04c0248e9f32756bfc0 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/dd07c651f732c2d20f2ba07a1fa7b7a7dedf0928 (beta)
https://github.com/mozilla/firefox-ui-tests/commit/a8f2a9e3d2245561ea883bc44502f9a05d15d512 (release)