Should be able to view hg pushlog from alert



3 years ago
3 years ago


(Reporter: wlach, Assigned: wlach)




(1 attachment)

You should be able to jump to the hg pushlog directly from the alert. Right now you either have to open the treeherder jobs view (for the overall alert) or view the graph (for each detected change). Both are slow and unwieldly.
Depends on: 1236732
Created attachment 8704207 [details] [review]
[treeherder] wlach:1236729 > mozilla:master
Comment on attachment 8704207 [details] [review]
[treeherder] wlach:1236729 > mozilla:master

There's a bunch of changes in here but I think it's all pretty straightforward.

Flagging mdoglio for feedback on some of the treeherder modifications.
Attachment #8704207 - Flags: review?(jmaher)
Attachment #8704207 - Flags: feedback?(mdoglio)
Comment on attachment 8704207 [details] [review]
[treeherder] wlach:1236729 > mozilla:master

I like the refactoring- I am not familiar with some of the changes, but two passes and nothing jumped out as "whoa, this is confusing or looks wrong".
Attachment #8704207 - Flags: review?(jmaher) → review+
Attachment #8704207 - Flags: feedback?(mdoglio) → feedback+
Assignee: nobody → wlachance

Comment 4

3 years ago
Commits pushed to master at
Bug 1236729 - Add and use a simplified method of getting a to/from pushlog

Before we had to construct it manually, it would be better for us to
add a function that we can reuse elsewhere in the repository model.
Start using this method in the graphs view.
Bug 1236729 - Resolve the promise on repository load in all cases

... even if the repository info is already loaded, we should still resolve
the promise.
Bug 1236729 - Allow user to go directly to hg pushlog from alerts view

Do this by adding a menu button with the revision which allows either
opening the treeherder jobs view or the hg pushlog.

Comment 5

3 years ago
Commit pushed to master at
Bug 1236729 - Fix some console errors on production

Turns out that the treeherder code currently tries to get a
pushlog href when revision is undefined sometimes. Gracefully
fail for that case, as we did before.
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.