1236729 - Should be able to view hg pushlog from alert

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

You should be able to jump to the hg pushlog directly from the alert. Right now you either have to open the treeherder jobs view (for the overall alert) or view the graph (for each detected change). Both are slow and unwieldly.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1236729 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8704207 [details] [review]
[treeherder] wlach:1236729 > mozilla:master

There's a bunch of changes in here but I think it's all pretty straightforward.

Flagging mdoglio for feedback on some of the treeherder modifications.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8704207 [details] [review]
[treeherder] wlach:1236729 > mozilla:master

I like the refactoring- I am not familiar with some of the changes, but two passes and nothing jumped out as "whoa, this is confusing or looks wrong".

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/89fe83294d0efa2bd24b5c52455cebf54764e5f4
Bug 1236729 - Add and use a simplified method of getting a to/from pushlog

Before we had to construct it manually, it would be better for us to
add a function that we can reuse elsewhere in the repository model.
Start using this method in the graphs view.

https://github.com/mozilla/treeherder/commit/1e39fd490a9b676233c698f1749fb7465e1ee797
Bug 1236729 - Resolve the promise on repository load in all cases

... even if the repository info is already loaded, we should still resolve
the promise.

https://github.com/mozilla/treeherder/commit/09a64e07a21efa48e491d8f59292d25bdda2eef2
Bug 1236729 - Allow user to go directly to hg pushlog from alerts view

Do this by adding a menu button with the revision which allows either
opening the treeherder jobs view or the hg pushlog.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/86fe3466c7bf8b49ffa8e663320dcc00bb7e392c
Bug 1236729 - Fix some console errors on production

Turns out that the treeherder code currently tries to get a
pushlog href when revision is undefined sometimes. Gracefully
fail for that case, as we did before.