Upgrade angular bootstrap to 0.14.3

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

I want this for my implementation of bug 1236729
Created attachment 8703896 [details] [review]
[treeherder] wlach:1236732 > mozilla:master
Comment on attachment 8703896 [details] [review]
[treeherder] wlach:1236732 > mozilla:master

This change should only effect perfherder, since after some investigation I'm pretty sure treeherder doesn't actually use angular bootstrap (it was dropped in by Cam ages ago for an accordion element which has since been removed).

I removed references to it from the logviewer. I would have removed it from inside mainline treeherder as well, except that Wes *will* be using it for bug 1117583 (for the modal element).
Attachment #8703896 - Flags: review?(emorley)

Updated

3 years ago
Attachment #8703896 - Flags: review?(emorley) → review+

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d28bfc9f551c21997cefcc55e44574615a9f3904
Bug 1236732 - Remove angular bootstrap include inside logviewer

It wasn't actually used, I think it came along in cut & paste.

https://github.com/mozilla/treeherder/commit/de479276ef7c2acc96269077dbde4a17b796e512
Bug 1236732 - Upgrade angular bootstrap to 0.14.3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.