1236852 - [Stingray] Network Error UI polish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Evelyn Hung]

The net_error.html page in System app isn't polished for TV. It currently displays a phone's layout and isn't interact-able.

Since network error might be caused by different reasons, we current have some cases in phone[1], but I'm not sure if we want to support all of them.

[1] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/locales/net_error.en-US.properties

Comment 1

[Evelyn Hung]

Attachment: no-connection.png

Comment 2

[Evelyn Hung]

Attachment: not-found.png

Comment 3

[Evelyn Hung]

Attachment: unable-reach.png

Comment 4

[Evelyn Hung]

Attached three different UI I see in phone's build. There might be more, but I can't enumerate them. Tori, could you check phone's UX spec to know all cases?

Comment 5

[Evelyn Hung]

Dan, we are waiting for UX spec but assign this bug to you first. Please ask Luke for more detail.

Comment 6

[Tori Chen [:tori]]

Hi Evelyn, I couldn't find the latest UX spec for phone since it hasn't updated for a long time. 

Forward the ni? to Jack.

Comment 7

[Jack Lin[:jacklin]]

Hi Evelyn,

Please see the spec as the link below,
https://drive.google.com/drive/u/0/folders/0BwbmH5cX2W6OWThiTmhhd3ZSUm8

Thank you 
Jack

Comment 8

[Josh Cheng [:josh]]

Hi Dan,
Do you have any update? Could you finish this before Jan/29?

Comment 9

[Dan Huang[:danhuang]]

Hi Josh,
code and layout are finished, wait for visual spec to finalize ui

Comment 10

[Josh Cheng [:josh]]

Jack,
Please provide spec thanks.

Comment 11

[Jack Lin[:jacklin]]

Hi Josh,

Visual spec is as the link below,
https://drive.google.com/open?id=0B4K8q1qWmtAvNTlPZGRZdXNzZnc

Thank you 
Jack

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1236852_network_error_ui_polish > mozilla-b2g:master

Comment 13

[Dan Huang[:danhuang]]

Comment on attachment 8713117 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish > mozilla-b2g:master

Hi Luke,
Please help review this patch. This patch revise network error according to UX and visual spec. Thanks.

Comment 14

[Dan Huang[:danhuang]]

Comment on attachment 8713117 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish > mozilla-b2g:master

Hi Yifan, please help review the browser part. This patch remove browser alert which shows when website content can't be displayed.

Comment 15

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8713117 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish > mozilla-b2g:master

Looks good except only a few comments. Remember to fix the linter errors before landing.

Comment 16

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: 
https://github.com/mozilla-b2g/gaia/commit/c7317c9d82af489a38218088abf9eb338b09c9a0

Comment 17

[Dan Huang[:danhuang]]

Comment on attachment 8713117 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1187806 
[User impact] if declined: The net error page not align to TV view
[Testing completed]:https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4598c9986d6135cfe76ad7d35b25b0353f598744
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 18

[Josh Cheng [:josh]]

Comment on attachment 8713117 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish > mozilla-b2g:master

Approve for TV 2.5

Comment 19

[Carsten Book [:Tomcat]]

has problems uplifting to master: Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 4598c9986d6135cfe76ad7d35b25b0353f598744
error: could not apply 4598c99... Bug 1236852 - Network Error UI polish. r=lchang, yifan
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

could you take a look and provide a 2.5 PR request thanks!

Comment 20

[Dan Huang[:danhuang]]

Attachment: patch for v2.5

Comment 21

[Dan Huang[:danhuang]]

Attachment: patch for v2.5

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1236852_network_error_ui_polish_v2.5 > mozilla-b2g:v2.5

Comment 23

[Dan Huang[:danhuang]]

Comment on attachment 8715167 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish_v2.5 > mozilla-b2g:v2.5

Hi Tomcat, please try this patch !

Comment 24

[Dan Huang[:danhuang]]

Comment on attachment 8715167 [details] [review]
[gaia] danhuang1202:1236852_network_error_ui_polish_v2.5 > mozilla-b2g:v2.5

Hi Tomcat, please try this patch !

Comment 25

[Carsten Book [:Tomcat]]

(In reply to Dan Huang[:danhuang] from comment #24)
> Comment on attachment 8715167 [details] [review]
> [gaia] danhuang1202:1236852_network_error_ui_polish_v2.5 > mozilla-b2g:v2.5
> 
> Hi Tomcat, please try this patch !

thanks Dan! pushed as https://github.com/mozilla-b2g/gaia/commit/8c68247e3045cde7445141e94e94104d617de03b

Comment 26

[cindylee]

This issue is verified on v2.6 latest build.
[Build Info]
2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/5873698d660f3e8639ab55f9900a1de0f3e43998
gecko:
https://hg.mozilla.org/mozilla-central/rev/dd1abe874252e507b825a0a4e1063b0e1357828

The error string is incorrect on v2,5 latest build when network offline.