1237069 - Implement option to record video capture of python UI tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Thanks to sotaro's Bug 1144103, now adb screenrecord <file location> command can record video of the device screen activity.  (with the right pref enabled).  Gaia UI test should have the option to record the video of the test, and push it to the PC when needed.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1237069 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

initial attempt

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

That's a great start!

I got it running on my Flame on a regular test case (not on the brick one though -- this one might be too quick to execute).

Even tough the code looks simple and works, I prefer not r+'ing yet. We can keep the separation of concerns by making DeviceManagerADB[1] in change of executing the command lines. Then gaiatest will be just a consumer of it, without knowing about the details. 

[1] https://dxr.mozilla.org/mozilla-central/rev/6020a4cb41a77a09484c24a5875bb221714c0e6a/testing/mozbase/mozdevice/mozdevice/devicemanagerADB.py)

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

I concur with Johan.

Comment 5

[No-Jun Park [:njpark]]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

incorporating comments

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

Tested without calling --capturefolder, I got the expected default behavior. I'm fine with landing this patch as is, in order to enable the feature quickly. The implementation in mozdevice might take a bit longer to integrate.

Comment 7

[No-Jun Park [:njpark]]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

implemented an option to pull only when there is a failure (Bug 1238943)

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8705821 [details] [review]
[gaia] npark-mozilla:1237069 > mozilla-b2g:master

Great piece of code!

I tried it out with a manifest that contained 2 tests:
* 1 passing and 1 having assertion error => It created the video only for the failing test
* 1 passing and 1 skipped (by disabling them and then manifest exclusion) => no video folder created if there was no failing test
* 1 assertion error and 1 time out error => got 2 videos in folder.

There is one nit that should be fixed before landing (default value should be "off"). I wont block on the second nit.

Comment 9

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #8)
> There is one nit that should be fixed before landing (default value should
> be "off"). I wont block on the second nit.

I apologize, I realized bug 1238943 was named "Make gaiatest --capture pull only the video of the failed test cases, by default". I see a potential confusion. 

When I filed the bug, --capture was a flag that didn't take any argument. Now, with the current implementation, it's fine to let the user type "whenfailed". It's even more self-explanatory. Then, please don't mind the title of bug 1238943 :)

Comment 11

[No-Jun Park [:njpark]]

Incorporated changes, so now the usage is as follows:
with no --capture parameter: same as before, no video capture
with --capture always: always pulls the captured video
with --capture whenfail: pulls the captured video only when the test fails by detecting the presence of exception

--capturefolder <foldername> creates the capture folder relative to the current active directory

Comment 12

[No-Jun Park [:njpark]]

Merged:
https://github.com/mozilla-b2g/gaia/commit/1522669d2a13d219e1697284da9c99049640beaf