[tc-gip] Turn on video recording

RESOLVED FIXED

Status

Firefox Build System
Task Configuration
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
With bug 1144103 and bug 1237069 being done, we can get a video of each test case that failed.
(Assignee)

Comment 1

2 years ago
Created attachment 8707413 [details]
MozReview Request: Bug 1239293 - [tc-gip] Turn on video recording

Review commit: https://reviewboard.mozilla.org/r/30681/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30681/
(Assignee)

Updated

2 years ago
Attachment #8707413 - Flags: review?(garndt)

Comment 2

2 years ago
Comment on attachment 8707413 [details]
MozReview Request: Bug 1239293 - [tc-gip] Turn on video recording

https://reviewboard.mozilla.org/r/30681/#review27675

::: testing/taskcluster/tasks/phone_test.yml:48
(Diff revision 1)
> +      'private/b2g/videos':

Are these videos large? Are they something we should be keeping around for a year? Just keeping that in mind as we add this.
Attachment #8707413 - Flags: review?(garndt) → review+
(Assignee)

Comment 3

2 years ago
These videos are usually 5MB long for a test that failed after 90 seconds. Firefox OS doesn't record more than 3 minutes. So worst case scenario, we have 1 video of 10MB.

Right now we have around 4 failures per tasks. Hence, the average usage per task will be around 20MB.

There are 6 (currently) failing jobs for each commit and about 10 commits a day. Then we'd require about 5.8TB the first year. Then, after a year, old videos will be discarded and we should maintain around the same usage.

Do you think taskcluster can handle this amount of data?

If not, I'm fine with reducing the expiration date to 3 months. The main use case is just to find out the reason of an intermittent failure.
Flags: needinfo?(garndt)

Comment 4

2 years ago
I don't think it's a crazy amount considering everything else that gets uploaded for a task.  Just wanted to make sure it wasn't like 1gb per task.  We can leave it like this if you think a year is sufficient.  Of course we would want to reduce that expiration down as much as we could to ensure we're not storing it for too long but also keep it around long enough to be useful for people.  Do you think people in 8 months will go back to look at these videos?
Flags: needinfo?(garndt)
(Assignee)

Comment 5

2 years ago
(In reply to Greg Arndt [:garndt] from comment #4)
> Do you think people in 8 months will go back to look at these videos?

Chatted with Martijn and NoJun. Martijn made a good point: if we want to keep a video, we can always attach it to a bug. Then 3 months will be enough. I'm updating the PR.
(Assignee)

Comment 6

2 years ago
Comment on attachment 8707413 [details]
MozReview Request: Bug 1239293 - [tc-gip] Turn on video recording

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30681/diff/1-2/
(Assignee)

Comment 8

2 years ago
There's an error in the configuration:
> [taskcluster] === Task Finished ===
> [taskcluster] Artifact "private/b2g/videos" not found at "/home/worker/upload/videos/"

Example: https://tools.taskcluster.net/task-inspector/#Tzmj4ollRm-onXB8sIijGA/0
Comment hidden (off-topic)
(Assignee)

Comment 11

2 years ago
After running half a dozen of tasks, I realized the video is never pulled to the docker container. 

In [1], for instance, you can see this hint in the logs:
> TEST-START | test_login_bzlite.py TestBugzillaLite.test_login_BugzillaLite
> * daemon not running. starting it now on port 5037 *
> * daemon started successfully *
> error: device not found
> TEST-UNEXPECTED-ERROR | test_login_bzlite.py TestBugzillaLite.test_login_BugzillaLite | TimeoutException: TimeoutException: Timed out after 30.3 seconds

This is the output of this line[2]: as we don't use mozdevice per se, we don't pass the ADB host/port/serial to the command line. Then, we require to implement the screen recorder function in mozdevice. 


[1] https://tools.taskcluster.net/task-inspector/#S-1Kzh3uRGephT9n7q-NkQ/0
[2] https://github.com/mozilla-b2g/gaia/pull/33815/files#diff-6d544bbb7c759ffb68f344f348f7740eR949
(Assignee)

Updated

2 years ago
Depends on: 1239964
(Assignee)

Comment 12

2 years ago
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #11)
> Then, we require to implement the screen recorder function in mozdevice. 

Tracked under bug 1239964.
No longer depends on: 1237069
(Assignee)

Comment 13

2 years ago
Comment on attachment 8707413 [details]
MozReview Request: Bug 1239293 - [tc-gip] Turn on video recording

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30681/diff/2-3/
(Assignee)

Comment 15

2 years ago
For the record: the patch bitrot due to bug 1225537 (phone_test.yml has been replaced by b2g_e2e_tests_base_definition.yml). Other than that, the changeset is exactly the same as the one reviewed.

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d83a10007bcc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1241138

Updated

3 months ago
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.