If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

tracking bug for build and release of Firefox 45.0 ESR

RESOLVED FIXED

Status

Release Engineering
Releases
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: rail, Assigned: jlund)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments, 4 obsolete attachments)

10.60 KB, patch
bhearsum
: review+
vladC
: checked-in+
Details | Diff | Splinter Review
68.17 KB, patch
bhearsum
: review+
vladC
: checked-in+
Details | Diff | Splinter Review
11.33 KB, patch
sylvestre
: review+
Details | Diff | Splinter Review
58 bytes, text/x-review-board-request
rail
: review+
nthomas
: review+
jlund
: checked-in+
Details | Review
101.42 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
6.98 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
(Reporter)

Description

2 years ago
* we need to setup a new branch
* new set of rules in Balrog, so buildbot manipulates only them (it worked fine in 38!)
* whatever we did last time :)
Since we're here, it would be nice to also document all the steps - if this doesn't exist yet - so that the next esr branching can be picked up easier.
(In reply to Mihai Tabara [:mtabara] from comment #1)
> Since we're here, it would be nice to also document all the steps - if this
> doesn't exist yet - so that the next esr branching can be picked up easier.

Vlad found https://wiki.mozilla.org/ReleaseEngineering/How_To/Create_new_ESR_branch already :). Things have probably changed a bit though.
Assignee: nobody → vlad.ciobancai
Created attachment 8722011 [details] [diff] [review]
bug1237094_tools-esr38+esr45.patch

Attached you can find the patch that updated tools repository by adding esr45 beside 38.

I tried to find a way to generate new files for esr45 in the following path tools/release/{updates,patcher-configs} but I was not able. 
:bhearsum suggested to leave it for the moment
Attachment #8722011 - Flags: review?(bhearsum)
Attachment #8722011 - Flags: review?(bhearsum) → review+
Created attachment 8722049 [details] [diff] [review]
bug1237094_buildbot-configs-esr38+esr45.patch

Attached you can find the patch where we added esr45 for buildbot-configs
Attachment #8722049 - Flags: review?(bhearsum)
Comment on attachment 8722049 [details] [diff] [review]
bug1237094_buildbot-configs-esr38+esr45.patch

Review of attachment 8722049 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8722049 - Flags: review?(bhearsum) → review+
Depends on: 1250609
Depends on: 1250610
Depends on: 1250612
Depends on: 1250613
Depends on: 1250617
Depends on: 1250618
I've gone and filed most of the dep bugs we need. Vlad, could you continue creating the necessary RelEng patches to create this branch, including the ones in the dependent bugs in RelEng?
Flags: needinfo?(vlad.ciobancai)
Depends on: 1250668
Flags: needinfo?(vlad.ciobancai)
Created attachment 8723101 [details] [diff] [review]
bug1237094_buildbot-configs-esr38+esr45.patch_v2

Attached the updated patch, I forgot to add the new templates for esr45 and pyt files for esr45
Attachment #8722049 - Attachment is obsolete: true
Attachment #8723101 - Flags: review?(bhearsum)
Attachment #8723101 - Attachment is patch: true
Attachment #8723101 - Attachment mime type: text/x-patch → text/plain
Attachment #8723101 - Flags: review?(bhearsum) → review+
Created attachment 8723590 [details] [diff] [review]
bug1237094_tools-esr38+esr45.patch

In the previews patch I missed to update the following file lib/python/util/fabric/actions.py
Attachment #8722011 - Attachment is obsolete: true
Attachment #8723590 - Flags: review?(bhearsum)
Created attachment 8723595 [details] [diff] [review]
bug1237094_buildbot-configs-esr38+esr45.patch

Updated the patch the following file l10n-changesets_mozilla-esr45 and l10n-changesets_thunderbird-esr45 was missed
Attachment #8723101 - Attachment is obsolete: true
Attachment #8723595 - Flags: review?(bhearsum)
Attachment #8723590 - Flags: review?(bhearsum) → review+
Attachment #8723595 - Flags: review?(bhearsum) → review+
Attachment #8723590 - Flags: checked-in+
Depends on: 1251285
Attachment #8723595 - Flags: checked-in+
In production: https://hg.mozilla.org/build/buildbot-configs/rev/8712d19cff79
AFAICT the branch set-up is done. There's some failing tests on my test push, but I'm not sure if they're intermittent or not: https://treeherder.allizom.org/#/jobs?repo=mozilla-esr45&selectedJob=7. Sylvestre, maybe you know who is the best person to look at them?

Vlad, I'm reassigning this to Jordan because this bug is also used to track the release, and he volunteered to handle that.

It's notable that the release config templates (https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/release-firefox-mozilla-esr45.py.template and https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/release-thunderbird-comm-esr45.py.template) still need some tweaks, definitely around the balrog rule ids, but possibly other things as well. This should happen prior to the releases being kicked off.
Assignee: vlad.ciobancai → jlund
Flags: needinfo?(sledru)
(Reporter)

Comment 12

2 years ago
Created attachment 8723759 [details] [diff] [review]
esr_branding.diff

We also need to update the branding images. Transplanted from esr38.

It'd be great to have aseparate directory with esr branding though.
Attachment #8723759 - Flags: review?(sledru)
Mac is packaging in the wrong objdir, and probably needs the equivalent of https://hg.mozilla.org/build/buildbot-configs/rev/615851873863 but somebody's going to have to page back in the memory of that whole bug.
I ran 'python manage_masters.py -f production-masters.json -R build -R scheduler add_esr45_symlinks' because we had some issues with starting Firefox 45.0b10. 

Please check the docs to make sure we land in this order:
1) land and merge buildbot-configs   (to provide the new config files on masters)
2) wait for auto-deploy to pull those in, or use fabric 'update' target
3) add the symlinks with manage_masters.py command above
4) land the tools change

The production-masters.json part of 4 needs 1-3 to be complete.
(In reply to Nick Thomas [:nthomas] from comment #14)
> I ran 'python manage_masters.py -f production-masters.json -R build -R
> scheduler add_esr45_symlinks' because we had some issues with starting
> Firefox 45.0b10. 
> 
> Please check the docs to make sure we land in this order:
> 1) land and merge buildbot-configs   (to provide the new config files on
> masters)
> 2) wait for auto-deploy to pull those in, or use fabric 'update' target
> 3) add the symlinks with manage_masters.py command above
> 4) land the tools change
> 
> The production-masters.json part of 4 needs 1-3 to be complete.

Thanks for that Nick. I updated the docs here: https://wiki.mozilla.org/index.php?title=ReleaseEngineering%2FHow_To%2FCreate_new_ESR_branch&diff=1118853&oldid=1118160
Comment on attachment 8723759 [details] [diff] [review]
esr_branding.diff

I haven't checked the image but as long as you don't use the iceweasel logo, I am fine with it!
Flags: needinfo?(sledru)
Attachment #8723759 - Flags: review?(sledru) → review+
Depends on: 1241501, 1232029
(Reporter)

Comment 17

2 years ago
Comment on attachment 8723759 [details] [diff] [review]
esr_branding.diff

https://hg.mozilla.org/releases/mozilla-esr45/rev/d2d75f526882
Attachment #8723759 - Flags: checked-in+
(Assignee)

Comment 18

2 years ago
Created attachment 8725336 [details]
MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas

Review commit: https://reviewboard.mozilla.org/r/37425/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37425/
Attachment #8725336 - Flags: review?(rail)
(Assignee)

Updated

2 years ago
Attachment #8725336 - Flags: feedback?(mtabara)
(Reporter)

Comment 19

2 years ago
Comment on attachment 8725336 [details]
MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas

https://reviewboard.mozilla.org/r/37425/#review33973
Attachment #8725336 - Flags: review?(rail) → review+
Attachment #8725336 - Flags: feedback?(mtabara) → feedback+
(In reply to Phil Ringnalda (:philor) from comment #13)
> Mac is packaging in the wrong objdir, and probably needs the equivalent of
> https://hg.mozilla.org/build/buildbot-configs/rev/615851873863 but
> somebody's going to have to page back in the memory of that whole bug.

This is causing OSX test bustage on multiple test suites. Is anybody following-up on it?
Flags: needinfo?(jlund)
Depends on: 1252572
Depends on: 1252328
(Assignee)

Comment 21

2 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #20)
> (In reply to Phil Ringnalda (:philor) from comment #13)
> > Mac is packaging in the wrong objdir, and probably needs the equivalent of
> > https://hg.mozilla.org/build/buildbot-configs/rev/615851873863 but
> > somebody's going to have to page back in the memory of that whole bug.
> 
> This is causing OSX test bustage on multiple test suites. Is anybody
> following-up on it?

I can look into this tomorrow
Flags: needinfo?(jlund)
(Assignee)

Updated

2 years ago
Attachment #8725336 - Flags: checked-in+
In production: https://hg.mozilla.org/build/buildbot-configs/rev/4b855f6b6eae
(Assignee)

Updated

2 years ago
Attachment #8725336 - Attachment description: MozReview Request: Bug 1237094 - tracking bug for Firefox 45.0 ESR, channel rules, bbot-cfgs, r?rail → MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas
Attachment #8725336 - Flags: feedback+ → review?(nthomas)
(Assignee)

Comment 23

2 years ago
Comment on attachment 8725336 [details]
MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37425/diff/1-2/
https://reviewboard.mozilla.org/r/37423/#review34227

r+

Updated

2 years ago
Attachment #8725336 - Flags: review?(nthomas) → review+
(Assignee)

Updated

2 years ago
Blocks: 1253066
Depends on: 1253139
Depends on: 1253140
Depends on: 1253141
Depends on: 1253410
Depends on: 1253505
(Reporter)

Comment 25

2 years ago
Created attachment 8726713 [details] [diff] [review]
esr45.tools.diff

Let's copy mozEsr38-branch-patcher2.cfg to mozEsr45-branch-patcher2.cfg and delete esr31 patcher configs. This will unbreak the update step, even thought we won't be publishing updates yet (but we can test them on the test channels).
Attachment #8726713 - Flags: review?(bhearsum)
(Reporter)

Comment 26

2 years ago
Comment on attachment 8726713 [details] [diff] [review]
esr45.tools.diff

Forgot to add empty update verify configs...
Attachment #8726713 - Flags: review?(bhearsum)
(Reporter)

Comment 27

2 years ago
Created attachment 8726722 [details] [diff] [review]
esr45.tools.diff

With UV configs this time. I used the new naming schema we used in release promotion. buildbot-configs patch incoming
Attachment #8726713 - Attachment is obsolete: true
Attachment #8726722 - Flags: review?(bhearsum)
(Reporter)

Comment 28

2 years ago
Created attachment 8726724 [details] [diff] [review]
win64_configs.diff
Attachment #8726724 - Flags: review?(bhearsum)
Comment on attachment 8726722 [details] [diff] [review]
esr45.tools.diff

Review of attachment 8726722 [details] [diff] [review]:
-----------------------------------------------------------------

diiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiie
Attachment #8726722 - Flags: review?(bhearsum) → review+
Comment on attachment 8726724 [details] [diff] [review]
win64_configs.diff

Review of attachment 8726724 [details] [diff] [review]:
-----------------------------------------------------------------

liiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiive
Attachment #8726724 - Flags: review?(bhearsum) → review+
(Reporter)

Comment 31

2 years ago
Comment on attachment 8726722 [details] [diff] [review]
esr45.tools.diff

https://hg.mozilla.org/build/tools/rev/aa534a1c7de4
Attachment #8726722 - Flags: checked-in+
(Reporter)

Comment 32

2 years ago
Comment on attachment 8726724 [details] [diff] [review]
win64_configs.diff

https://hg.mozilla.org/build/buildbot-configs/rev/f65f8e566a68
Attachment #8726724 - Flags: checked-in+
In production: https://hg.mozilla.org/build/buildbot-configs/rev/f65f8e566a68

Updated

2 years ago
Depends on: 1254784
Depends on: 1254611

Updated

2 years ago
Depends on: 1255245
(Reporter)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.