1237094 - tracking bug for build and release of Firefox 45.0 ESR

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Rail Aliiev [:rail]]

* we need to setup a new branch
* new set of rules in Balrog, so buildbot manipulates only them (it worked fine in 38!)
* whatever we did last time :)

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Since we're here, it would be nice to also document all the steps - if this doesn't exist yet - so that the next esr branching can be picked up easier.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Mihai Tabara [:mtabara] from comment #1)
> Since we're here, it would be nice to also document all the steps - if this
> doesn't exist yet - so that the next esr branching can be picked up easier.

Vlad found https://wiki.mozilla.org/ReleaseEngineering/How_To/Create_new_ESR_branch already :). Things have probably changed a bit though.

Comment 3

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1237094_tools-esr38+esr45.patch

Attached you can find the patch that updated tools repository by adding esr45 beside 38.

I tried to find a way to generate new files for esr45 in the following path tools/release/{updates,patcher-configs} but I was not able. 
:bhearsum suggested to leave it for the moment

Comment 4

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1237094_buildbot-configs-esr38+esr45.patch

Attached you can find the patch where we added esr45 for buildbot-configs

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8722049 [details] [diff] [review]
bug1237094_buildbot-configs-esr38+esr45.patch

Review of attachment 8722049 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 6

[[e-mail] (:bhearsum)]

I've gone and filed most of the dep bugs we need. Vlad, could you continue creating the necessary RelEng patches to create this branch, including the ones in the dependent bugs in RelEng?

Comment 7

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1237094_buildbot-configs-esr38+esr45.patch_v2

Attached the updated patch, I forgot to add the new templates for esr45 and pyt files for esr45

Comment 8

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1237094_tools-esr38+esr45.patch

In the previews patch I missed to update the following file lib/python/util/fabric/actions.py

Comment 9

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1237094_buildbot-configs-esr38+esr45.patch

Updated the patch the following file l10n-changesets_mozilla-esr45 and l10n-changesets_thunderbird-esr45 was missed

Comment 10

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/8712d19cff79

Comment 11

[[e-mail] (:bhearsum)]

AFAICT the branch set-up is done. There's some failing tests on my test push, but I'm not sure if they're intermittent or not: https://treeherder.allizom.org/#/jobs?repo=mozilla-esr45&selectedJob=7. Sylvestre, maybe you know who is the best person to look at them?

Vlad, I'm reassigning this to Jordan because this bug is also used to track the release, and he volunteered to handle that.

It's notable that the release config templates (https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/release-firefox-mozilla-esr45.py.template and https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/release-thunderbird-comm-esr45.py.template) still need some tweaks, definitely around the balrog rule ids, but possibly other things as well. This should happen prior to the releases being kicked off.

Comment 12

[Rail Aliiev [:rail]]

Attachment: esr_branding.diff

We also need to update the branding images. Transplanted from esr38.

It'd be great to have aseparate directory with esr branding though.

Comment 13

[Phil Ringnalda (:philor)]

Mac is packaging in the wrong objdir, and probably needs the equivalent of https://hg.mozilla.org/build/buildbot-configs/rev/615851873863 but somebody's going to have to page back in the memory of that whole bug.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

I ran 'python manage_masters.py -f production-masters.json -R build -R scheduler add_esr45_symlinks' because we had some issues with starting Firefox 45.0b10. 

Please check the docs to make sure we land in this order:
1) land and merge buildbot-configs   (to provide the new config files on masters)
2) wait for auto-deploy to pull those in, or use fabric 'update' target
3) add the symlinks with manage_masters.py command above
4) land the tools change

The production-masters.json part of 4 needs 1-3 to be complete.

Comment 15

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] from comment #14)
> I ran 'python manage_masters.py -f production-masters.json -R build -R
> scheduler add_esr45_symlinks' because we had some issues with starting
> Firefox 45.0b10. 
> 
> Please check the docs to make sure we land in this order:
> 1) land and merge buildbot-configs   (to provide the new config files on
> masters)
> 2) wait for auto-deploy to pull those in, or use fabric 'update' target
> 3) add the symlinks with manage_masters.py command above
> 4) land the tools change
> 
> The production-masters.json part of 4 needs 1-3 to be complete.

Thanks for that Nick. I updated the docs here: https://wiki.mozilla.org/index.php?title=ReleaseEngineering%2FHow_To%2FCreate_new_ESR_branch&diff=1118853&oldid=1118160

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8723759 [details] [diff] [review]
esr_branding.diff

I haven't checked the image but as long as you don't use the iceweasel logo, I am fine with it!

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 8723759 [details] [diff] [review]
esr_branding.diff

https://hg.mozilla.org/releases/mozilla-esr45/rev/d2d75f526882

Comment 18

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas

Review commit: https://reviewboard.mozilla.org/r/37425/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37425/

Comment 19

[Rail Aliiev [:rail]]

Comment on attachment 8725336 [details]
MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas

https://reviewboard.mozilla.org/r/37425/#review33973

Comment 20

[Ryan VanderMeulen [:RyanVM]]

(In reply to Phil Ringnalda (:philor) from comment #13)
> Mac is packaging in the wrong objdir, and probably needs the equivalent of
> https://hg.mozilla.org/build/buildbot-configs/rev/615851873863 but
> somebody's going to have to page back in the memory of that whole bug.

This is causing OSX test bustage on multiple test suites. Is anybody following-up on it?

Comment 21

[Jordan Lund (:jlund)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #20)
> (In reply to Phil Ringnalda (:philor) from comment #13)
> > Mac is packaging in the wrong objdir, and probably needs the equivalent of
> > https://hg.mozilla.org/build/buildbot-configs/rev/615851873863 but
> > somebody's going to have to page back in the memory of that whole bug.
> 
> This is causing OSX test bustage on multiple test suites. Is anybody
> following-up on it?

I can look into this tomorrow

Comment 22

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/4b855f6b6eae

Comment 23

[Jordan Lund (:jlund)]

Comment on attachment 8725336 [details]
MozReview Request: Bug 1237094 - tracking bug for build and release of Firefox 45.0 ESR, r?nthomas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37425/diff/1-2/

Comment 24

[Nick Thomas [:nthomas] (UTC+12)]

https://reviewboard.mozilla.org/r/37423/#review34227

r+

Comment 25

[Rail Aliiev [:rail]]

Attachment: esr45.tools.diff

Let's copy mozEsr38-branch-patcher2.cfg to mozEsr45-branch-patcher2.cfg and delete esr31 patcher configs. This will unbreak the update step, even thought we won't be publishing updates yet (but we can test them on the test channels).

Comment 26

[Rail Aliiev [:rail]]

Comment on attachment 8726713 [details] [diff] [review]
esr45.tools.diff

Forgot to add empty update verify configs...

Comment 27

[Rail Aliiev [:rail]]

Attachment: esr45.tools.diff

With UV configs this time. I used the new naming schema we used in release promotion. buildbot-configs patch incoming

Comment 28

[Rail Aliiev [:rail]]

Attachment: win64_configs.diff

Comment 29

[[e-mail] (:bhearsum)]

Comment on attachment 8726722 [details] [diff] [review]
esr45.tools.diff

Review of attachment 8726722 [details] [diff] [review]:
-----------------------------------------------------------------

diiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiie

Comment 30

[[e-mail] (:bhearsum)]

Comment on attachment 8726724 [details] [diff] [review]
win64_configs.diff

Review of attachment 8726724 [details] [diff] [review]:
-----------------------------------------------------------------

liiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiive

Comment 31

[Rail Aliiev [:rail]]

Comment on attachment 8726722 [details] [diff] [review]
esr45.tools.diff

https://hg.mozilla.org/build/tools/rev/aa534a1c7de4

Comment 32

[Rail Aliiev [:rail]]

Comment on attachment 8726724 [details] [diff] [review]
win64_configs.diff

https://hg.mozilla.org/build/buildbot-configs/rev/f65f8e566a68

Comment 33

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/f65f8e566a68