Closed Bug 1237145 Opened 6 years ago Closed 6 years ago

Disable decoding unencrypted video using Adobe's GMP

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

We've discovered that the Adobe GMP can't handle some HE-AAC streams. Facebook uses these, so when decoding using the Adobe GMP is enabled, Facebook video is broken!

So we should turn off unencrypted decoding using Adobe's GMP until Adobe can fix this.
Assignee: nobody → cpearce
Attachment #8704443 - Flags: review?(ajones) → review+
Comment on attachment 8704443 [details]
MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/29663/#review26489
Needs uplift to 45.
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/19cff55f4b82
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8704443 [details]
MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: Bug 1210231 
[User impact if declined]: Video in Facebook news stream will fail to play for users without Windows platform decoders installed (Windows N/KN variants, and some Vista users).
[Describe test coverage new/current, TreeHerder]: We don't have a test for Adobe GMP video decoding.
[Risks and why]: Low; this reverts us to a previous known state (no HTML5 H.264/AAC/MP4 playback for these users). These users will get Flash video in their Facebook news stream.
[String/UUID change made/needed]: None.

We'll need the release notes updated to remove the note added in Bug 1210231.
Flags: needinfo?(cpearce)
Attachment #8704443 - Flags: approval-mozilla-aurora?
Comment on attachment 8704443 [details]
MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

Sure, do you have an idea in which version we are going to propose the change?
Attachment #8704443 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> Comment on attachment 8704443 [details]
> MozReview Request: Bug 1237145 - Disable decoding unencrypted video using
> Adobe's GMP. r?kentuckyfriedtakahe
> 
> Sure, do you have an idea in which version we are going to propose the
> change?

I'd like to re-enable this in 45 once Adobe have produced a EME plugin with the garbled audio bug fixed.
You need to log in before you can comment on or make changes to this bug.