1237145 - Disable decoding unencrypted video using Adobe's GMP

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We've discovered that the Adobe GMP can't handle some HE-AAC streams. Facebook uses these, so when decoding using the Adobe GMP is enabled, Facebook video is broken!

So we should turn off unencrypted decoding using Adobe's GMP until Adobe can fix this.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

Review commit: https://reviewboard.mozilla.org/r/29663/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29663/

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8704443 [details]
MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/29663/#review26489

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19cff55f4b82

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Needs uplift to 45.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/19cff55f4b82

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8704443 [details]
MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: Bug 1210231 
[User impact if declined]: Video in Facebook news stream will fail to play for users without Windows platform decoders installed (Windows N/KN variants, and some Vista users).
[Describe test coverage new/current, TreeHerder]: We don't have a test for Adobe GMP video decoding.
[Risks and why]: Low; this reverts us to a previous known state (no HTML5 H.264/AAC/MP4 playback for these users). These users will get Flash video in their Facebook news stream.
[String/UUID change made/needed]: None.

We'll need the release notes updated to remove the note added in Bug 1210231.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8704443 [details]
MozReview Request: Bug 1237145 - Disable decoding unencrypted video using Adobe's GMP. r?kentuckyfriedtakahe

Sure, do you have an idea in which version we are going to propose the change?

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f95067c59a1

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> Comment on attachment 8704443 [details]
> MozReview Request: Bug 1237145 - Disable decoding unencrypted video using
> Adobe's GMP. r?kentuckyfriedtakahe
> 
> Sure, do you have an idea in which version we are going to propose the
> change?

I'd like to re-enable this in 45 once Adobe have produced a EME plugin with the garbled audio bug fixed.